Fix inconsistent configuration (specifically RecordRtts). #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes SuperQ#42. Signed-off-by: Carl Kittelberger <icedream@icedream.pw>
icedream
force-pushed
the
pr/fix-inconsistent-config
branch
from
b7de9cd
to
14c4a39
Compare
SuperQ
approved these changes
Jun 8, 2022
SuperQ
added a commit
that referenced
this pull request
Jun 8, 2022
* [BUGFIX] Fix RecordRtts memory leak for config file targets #73 Signed-off-by: SuperQ <superq@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original fix for memory leaks #49 only disabled the RTT tracking code for hosts configured via CLI, not for hosts configured dynamically via SafeConfig.
Fixes #42.
(Also removes unnecessary explicit setting of Timeout to maximum value, that's the default in go-ping.)