Fix issue with live fire not fading after colliding with bomb #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1403, at least partially. The walking fire will fade properly when Tux collides with it while carrying a bomb. Demo below:
Before:
After:
However, the fire still goes diagonally down while fading (into the ground), which looks awkward. But at least it fades.
The problem was in
LiveFire::active_updateline 63-66, if state was stillSTATE_WALKING, the sprite action would be set to regular walking (not fading) just after hitting the bomb. Since collision group is set toCOLGROUP_DISABLED, it also would not interact with objects anymore. So an extra state is addedSTATE_DEADto avoid this.