Pull Request to change the Boat by swimming Tux #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rusty-Box
requested changes
Jun 25, 2020
Rusty-Box
added
category:design
status:conditional
|
Change the name of folder and of .sprite? |
|
y e s |
|
@JL0027 Yes and No |
@AndrePinheiroPT Do not change the name of the folder! Put your sprites into the 'common' folder. |
|
Ok, I get it! |
Rusty-Box
approved these changes
Jun 26, 2020
|
Great animation, but couldn't we use sprite rotation to handle Tux swimming up and down as opposed to having two duplicated versions of every swimming sprite? |
|
@Alzter does mirror action even allow for horizontal flipping? From my knowledge you can only mirror vertically with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apresentation
Sorry for my bad english
Hi, my name is André Pinheiro, I live in Portugal and I want to present my idea to you.
My ideia is change the boat for swimming tux in worldmap, the question is...
My arguments
Well, I my opinion, the boat sprite is too old and for me, it does make sense in the game. In fact, the swimming tux is the best option because with the new swimming feature added to the game, it would make more sense to have the swimming tux on the worldmap instead of a boat. I also think the boat sprite is weak on quality issues, have you noticed that?
The sprite
Well, I tried make it similar to the existing worldmap sprites in the game and the moviment of swimmig tux, here you have two gifs to take your conclusions...
How to use?
Its simple, just enter a worldmap that had the boat sprite and have fun :)
Modifications
I modified the data/images/worldmap/common/boat and src/worldmap/tux.cpp
Credits
Animation of Tux - Me
The hats - Frost