Add Falling Platform #1469
Merged
Add Falling Platform #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papb
reviewed
Jul 18, 2020
tux314159
pushed a commit
to tux314159/supertux
that referenced
this pull request
Jul 31, 2020
* Add fallblocks [ci skip] * Update game object factory [ci skip] * Add images [ci skip] * Update objects file * update due to review * Delete cave-5x8.png [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the falling platform into the game. The platform will shake when Tux is under or on it and after a short while it will fall. This lacks a unisolid variant seen as that would be impossible/very difficult in the current way this game is set up, and a unisolid variant would remove the challenge that this obstacle is meant to have. This comes with sprites for branches and cave terrain.
This object behaves strange with enemies and some objects, but this seems to be a problem with how collision is handled over the whole game.
This PR needs some testing and some review, once it's reviewed and fixed up a bit it can probably get merged. This definitely needs some work done to it.