Fixed bug where ScriptTrigger areas wouldn't save their name #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Adding the key name to the ObjectSettings on line 75 of src/trigger/scripttrigger.cpp (old version) wasn't enough, I had to refactor the code a bit (made it cleaner too)
tobbi
reviewed
Dec 27, 2020
| if (reader.get("height", height)) | ||
| m_col.m_bbox.set_height(height); | ||
|
|
||
| reader.get("x", m_col.m_bbox.get_left()); |
There was a problem hiding this comment.
I'm confused about this. the get_left() and get_top() methods are marked const. However, they're passed by reference to the reader.get() method which might attempt to save a value, which should fail. Can you please test this?
There was a problem hiding this comment.
@tobbi There is another place in the code that uses the exact same trick, the author called it a "temporary hack" (which I (or anyone) should fix someday). Two overloads for that function, of which one is a non-const reference.
There was a problem hiding this comment.
Very interesting. OKay, I'm gonna merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Adding the key name to the ObjectSettings on line 75 of src/trigger/scripttrigger.cpp (old version) wasn't enough, I had to refactor the code a bit (made it cleaner too)