Added fade helpers to help clean code in game objects #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobbi
reviewed
Jan 14, 2021
tobbi
reviewed
Jan 14, 2021
tobbi
reviewed
Jan 17, 2021
(Repeating an internal discussion here) This kind of change is recommended when the body of the if statement is considered a special case of some sort. If both cases are considered equivalent in importance and complementary (say, an easing function that uses a certain body for values [0, 0.5[ and another for [0.5, 1]), then keeping the else is recommended so that the code *looks* like it gives equal importance to both parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FadeHelper will make it much easier to write fading code inside GameObjects and any
update()-able class.Note: This helper has yet to be used inside the code. A refactor would be needed. I can do this, but if you think this PR is a good idea, I would really appreciate your help :)