UI improvements #1662
Merged
UI improvements #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 29, 2021 00:00
- Improved selection: pressing left or right while having text selected will move the caret to the beginning or the end of the text selection, respectively (and clear the selection) - Refactored the handling of the backspace key to make it similar to the handling of the delete key. This allows the usage of the regular update() function and makes controls compatible with Widgets again, in addition to make the code generally cleaner.
This was referenced Jan 29, 2021
|
What is the status of this one? Can it get merged? |
|
Yes, in fact it's part of the editor revamp that I never finished. If I tagged it as ready for review, it should be ready for merge. |
mrkubax10
removed
the
status:needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #1659 and #1660.
List of changes: