Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed handling of Tux movement #1680

Merged
merged 4 commits into from
Mar 5, 2021

Conversation

Semphriss
Copy link
Member

  • Removed speed ceiling that gets applied whenever the player presses a certain direction. Now, limits are applies regardless of what the player presses, and the speed is brought back within limits smoothly rather than instantly.
  • Added a boost mechanism, to help Tux gain extra velocity above speed limits for a short amount of time (useful for bumpers).
  • Fixed the one-wall walljump-climbing bug.

- Removed speed ceiling that gets applied whenever the player presses a certain direction. Now, limits are applies regardless of what the player presses, and the speed is brought back within limits smoothly rather than instantly.
- Added a boost mechanism, to help Tux gain extra velocity above speed limits for a short amount of time (useful for bumpers).
- Fixed the one-wall walljump-climbing bug.
@Semphriss
Copy link
Member Author

@Zwatotem Any comments? I can't get very far with just an emoji :^)

@Zwatotem
Copy link
Member

I just liked the climbing bug. But that's okay if you fixed it. Can't give feedback on the rest right now.

@Semphriss
Copy link
Member Author

I removed the climbing bug because it opened the door to poor level design, both by level designers that will expect players to use it and those who don't.

We also discussed about Tux's moveset the other day, and we agreed that double-wall walljumping would be the ceiling in terms of mobility for Tux. (Ngl, I would prefer not have a fat penguin have the moveset of a ninja 👀)

@weluvgoatz
Copy link
Member

This feature is good, I approve of the merge but I'll wait for others to chime in. :)

@weluvgoatz
Copy link
Member

I remember this PR working quite well, are there any objections to it?

@Semphriss
Copy link
Member Author

Semphriss commented Mar 4, 2021

Merge conflicts are solved, so once all the builds passed, it's whenever you want :^)

@weluvgoatz
Copy link
Member

Gonna merge this now, thanks.

@weluvgoatz weluvgoatz merged commit d4abd06 into SuperTux:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants