Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added color support for Will'O'Wisps #1708

Merged
merged 3 commits into from
Mar 30, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/badguy/badguy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@ BadGuy::BadGuy(const Vector& pos, Direction direction, const std::string& sprite
m_melting_time(0),
m_lightsprite(SpriteManager::current()->create(light_sprite_name)),
m_glowing(false),
m_parent_dispenser(),
m_state(STATE_INIT),
m_is_active_flag(),
m_state_timer(),
m_on_ground_flag(false),
m_floor_normal(),
m_colgroup_active(COLGROUP_MOVING),
m_parent_dispenser()
m_colgroup_active(COLGROUP_MOVING)
{
SoundManager::current()->preload("sounds/squish.wav");
SoundManager::current()->preload("sounds/fall.wav");
Expand Down Expand Up @@ -98,13 +98,13 @@ BadGuy::BadGuy(const ReaderMapping& reader, const std::string& sprite_name_, int
m_melting_time(0),
m_lightsprite(SpriteManager::current()->create(light_sprite_name)),
m_glowing(false),
m_parent_dispenser(),
m_state(STATE_INIT),
m_is_active_flag(),
m_state_timer(),
m_on_ground_flag(false),
m_floor_normal(),
m_colgroup_active(COLGROUP_MOVING),
m_parent_dispenser()
m_colgroup_active(COLGROUP_MOVING)
{
std::string dir_str = "auto";
reader.get("direction", dir_str);
Expand Down
8 changes: 4 additions & 4 deletions src/badguy/badguy.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,10 @@ class BadGuy : public MovingSprite,
SpritePtr m_lightsprite;
bool m_glowing;

/** If this badguy was dispensed from a dispenser,
save the dispenser here. */
Dispenser* m_parent_dispenser;

private:
State m_state;

Expand All @@ -278,10 +282,6 @@ class BadGuy : public MovingSprite,
/** CollisionGroup the badguy should be in while active */
CollisionGroup m_colgroup_active;

/** If this badguy was dispensed from a dispenser,
save the dispenser here. */
Dispenser* m_parent_dispenser;

private:
BadGuy(const BadGuy&) = delete;
BadGuy& operator=(const BadGuy&) = delete;
Expand Down
6 changes: 6 additions & 0 deletions src/badguy/treewillowisp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

#include "audio/sound_manager.hpp"
#include "audio/sound_source.hpp"
#include "badguy/dispenser.hpp"
#include "badguy/ghosttree.hpp"
#include "math/util.hpp"
#include "object/lantern.hpp"
Expand Down Expand Up @@ -67,6 +68,11 @@ TreeWillOWisp::vanish()
mystate = STATE_VANISHING;
m_sprite->set_action("vanishing", 1);
set_colgroup_active(COLGROUP_DISABLED);

if (m_parent_dispenser != nullptr)
{
m_parent_dispenser->notify_dead();
}
}

void
Expand Down
30 changes: 28 additions & 2 deletions src/badguy/willowisp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

#include "audio/sound_manager.hpp"
#include "audio/sound_source.hpp"
#include "badguy/dispenser.hpp"
#include "editor/editor.hpp"
#include "object/lantern.hpp"
#include "object/player.hpp"
Expand All @@ -44,7 +45,8 @@ WillOWisp::WillOWisp(const ReaderMapping& reader) :
m_sound_source(),
m_flyspeed(),
m_track_range(),
m_vanish_range()
m_vanish_range(),
m_color(0, 1, 0)
{
if (Editor::is_active()) {
reader.get("sector", m_target_sector);
Expand All @@ -62,13 +64,22 @@ WillOWisp::WillOWisp(const ReaderMapping& reader) :
bool running;
if ( !reader.get("running", running)) running = false;

std::vector<float> color;
if (reader.get("color", color))
{
m_color = Color(color);
}

init_path(reader, running);

m_countMe = false;
SoundManager::current()->preload(SOUNDFILE);
SoundManager::current()->preload("sounds/warp.wav");

m_lightsprite->set_color(Color(0.0f, 0.2f, 0.0f));
m_lightsprite->set_color(Color(m_color.red * 0.2f,
m_color.green * 0.2f,
m_color.blue * 0.2f));
m_sprite->set_color(m_color);
m_glowing = true;

m_sprite->set_action("idle");
Expand All @@ -82,6 +93,15 @@ WillOWisp::finish_construction()
}
}

void
WillOWisp::after_editor_set()
{
m_lightsprite->set_color(Color(m_color.red * 0.2f,
m_color.green * 0.2f,
m_color.blue * 0.2f));
m_sprite->set_color(m_color);
}

void
WillOWisp::active_update(float dt_sec)
{
Expand Down Expand Up @@ -192,6 +212,11 @@ WillOWisp::vanish()
m_mystate = STATE_VANISHING;
m_sprite->set_action("vanishing", 1);
set_colgroup_active(COLGROUP_DISABLED);

if (m_parent_dispenser != nullptr)
{
m_parent_dispenser->notify_dead();
}
}

bool
Expand Down Expand Up @@ -284,6 +309,7 @@ WillOWisp::get_settings()
result.add_float(_("Vanish range"), &m_vanish_range, "vanish-range", VANISH_RANGE);
result.add_float(_("Fly speed"), &m_flyspeed, "flyspeed", FLYSPEED);
result.add_path_ref(_("Path"), get_path_ref(), "path-ref");
result.add_color(_("Color"), &m_color, "color");

result.reorder({"sector", "spawnpoint", "flyspeed", "track-range", "hit-script", "vanish-range", "name", "path-ref", "region", "x", "y"});

Expand Down
5 changes: 5 additions & 0 deletions src/badguy/willowisp.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ class WillOWisp final :
WillOWisp(const ReaderMapping& reader);

virtual void finish_construction() override;
virtual void after_editor_set() override;

virtual void activate() override;
virtual void deactivate() override;
Expand Down Expand Up @@ -70,6 +71,8 @@ class WillOWisp final :
/** make WillOWisp vanish */
void vanish();

Color get_color() { return m_color; }
Semphriss marked this conversation as resolved.
Show resolved Hide resolved

private:
virtual bool collides(GameObject& other, const CollisionHit& hit) const override;
virtual HitResponse collision_player(Player& player, const CollisionHit& hit) override;
Expand All @@ -92,6 +95,8 @@ class WillOWisp final :
float m_track_range;
float m_vanish_range;

Color m_color;

private:
WillOWisp(const WillOWisp&) = delete;
WillOWisp& operator=(const WillOWisp&) = delete;
Expand Down
2 changes: 1 addition & 1 deletion src/object/lantern.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ HitResponse Lantern::collision(GameObject& other, const CollisionHit& hit) {
if (wow) {
// collided with WillOWisp while grabbed and unlit
SoundManager::current()->play("sounds/willocatch.wav");
lightcolor = Color(0,1,0);
lightcolor = wow->get_color();
updateColor();
wow->vanish();
}
Expand Down