Replace Vector with glm::vec2 #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grumbel
force-pushed
the
feature/glm
branch
3 times, most recently
from
3dc4a4c
to
a6dee17
Compare
Grumbel
force-pushed
the
feature/glm
branch
4 times, most recently
from
e10a354
to
0a9620b
Compare
Grumbel
force-pushed
the
feature/glm
branch
2 times, most recently
from
211bbfb
to
b4484e8
Compare
glm types behave like primitive C types, so explicit initialization is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the homebrewn Vector with glm, which is a C++ math library based on the math functions from OpenGL's GLSL. The library also has matrixes, quartanions, int-vectors and a bunch of more stuff that could be handy in the future.
glm should be available in most distributions these days.
One important caveat to be aware of: glm types behaves like primitive C types, so everything needs to be explicitly initialized.