Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glm check failing on Nix and EmuELEC #1753

Merged
merged 1 commit into from May 20, 2021
Merged

Fix glm check failing on Nix and EmuELEC #1753

merged 1 commit into from May 20, 2021

Conversation

Grumbel
Copy link
Member

@Grumbel Grumbel commented May 19, 2021

Fixes #1752

@weluvgoatz
Copy link
Member

I get the error that the ALIAS target "glm::glm" cannot be created because target "glm" is imported but not globally visible.

@Grumbel
Copy link
Member Author

Grumbel commented May 19, 2021

Older versions of cmake don't allow aliases on imported targets. We can either up the requirement to cmake 3.11 (or 3.18?) or do the aliasing manually.

@Grumbel Grumbel merged commit 182dd5f into master May 20, 2021
@Grumbel Grumbel deleted the issue/1752 branch May 20, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After the change to GLM it now fails to compile
2 participants