Remove sky from snow backgrounds #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected backgrounds: arctis2.png and arcticmountain.png
Use version of arctis2 background with sky for the level editor start screen.
Rusty-Box
added
involves:editor
category:design
status:needs-review
|
I'm not against it, but what's the occasion? Plus, after merging, someone needs to add a gradient for the levels which are using them, otherwise they will have a black void visible. |
|
@serano01 This allows these backgrounds to be layered and combined together. This is also beneficial for having them set at different times of day or varing sky colors in general. Also, I personally see them having much more of a future then parallax tiles (atleast the way we use them right now). |
mrkubax10
removed
the
status:needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The affected snow backgrounds are: arctis2.png and arcticmountain.png
I still kept the not transparent version of arctis2 to be used as the background for the level editor's start screen without the black void visible. It is located separately from the other backgrounds in
images/engine/menu/to not cause confusion.