Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to save level under a different name #1881

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

Semphriss
Copy link
Member

editor-save-as.mp4

This PR adds two options to the level editor menu:

  • Save Level as
  • Save Copy

Both save the current level under a different filename; the difference between both is that "Save Level as" will make the editor track the new given filename, and subsequent saves will be written to that new file, whereas "Save Copy" will write to the given file only once and the editor will keep tracking the regular file.

@Zwatotem
Copy link
Member

Does this feature have file extension inference? Should we force one? Should it be OS-dependent?

@Semphriss
Copy link
Member Author

It does not enforce any filename restriction. I originally wanted to copy the mechanism to create a level, but I realized it does not take a filename, it automatically generates one. I'm open to any recommendation about validation.

However, it does handle path separator conversion properly (forward vs backwards slashes).

@weluvgoatz weluvgoatz merged commit 7fbeeda into SuperTux:master Nov 11, 2021
@Zwatotem
Copy link
Member

Most windows programs automatically add a file extension after the name, if you don't input it yourself. Users can be used to this. There is also an option to change the file type in a drop down to "All file types" position, and then it saves it literally, like here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants