Removed crash-inducing assertions with autotiles #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Placing a tile outside of a tilemap (for example, when having a tilemap smaller than the sector selected then attempting to autotile outside the bounds of the tilemap) would trigger a failing assert and crash the game. This commit replaces such events with a harmless return statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placing a tile outside of a tilemap (for example, when having a tilemap smaller than the sector selected then attempting to autotile outside the bounds of the tilemap) would trigger a failing assert and crash the game. This commit replaces such events with a harmless return statement.
Closes #1934
The PR above misses a few other assertions in the code. This PR takes care of all assertions relating to autotiles, and additionally improves the code quality a bit.
Fixes #1907