Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconsistent jump height when jumping from a climbable #1947

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

Semphriss
Copy link
Member

Prior to this fix, it was possible that jumping while climbing would refuse to do a large jump, no matter how long the jump button was pressed. This is because the code that handles jumping while climbing is not the same as the usual one, and it forgot to handle the early apex.
Steps to reproduce the bug:

  • In a level, navigate to a location with a tall climbable zone with walkable land below it
  • Go right below the climbable zone
  • Start jumping and hold, as to do a high jump
  • Before reaching the apex, interrupt your jump (as if you changed your mind and wanted to do a small jump), and immediately after (not before, after), press and hold up to start climbing
  • From there, attempt to do a high jump. Prior to this commit, it would fail and force the early apex on you; after, it will do a high jump, as expected.

Fixes #1905

Prior to this fix, it was possible that jumping while climbing would refuse to do a large jump, no matter how long the jump button was pressed. This is because the code that handles jumping while climbing is not the same as the usual one, and it forgot to handle the early apex.
Steps to reproduce the bug:
- In a level, navigate to a location with a tall climbable zone with walkable land below it
- Go right below the climbable zone
- Start jumping and hold, as to do a high jump
- Before reaching the apex, interrupt your jump (as if you changed your mind and wanted to do a small jump), and immediately after (not before, after), press and hold up to start climbing
- From there, attempt to do a high jump. Prior to this commit, it would fail and force the early apex on you; after, it will do a high jump, as expected.
@weluvgoatz weluvgoatz added the type:bugfix Pull Requests that fix bugs. label Dec 15, 2021
@tobbi tobbi merged commit 640981e into SuperTux:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bugfix Pull Requests that fix bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jumping off a climbable object is still inconsistent
3 participants