New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix changing sprites of certain objects in editor #1964
Conversation
@Narre I've updated the PR to include those changes. Big thanks for the catch about flames, I wasn't aware of that! Could you (or anyone familiar with C++) review my modifications with the #include's in the flame files? Since I removed some stuff to make it more flexible, I saw I could simplify the whole thing, but I'm not sure if my edits are optimal, so I'd like to be reviewed on this by someone, if possible. |
I tested it and it all seems to be working correctly :) As for the review, I'm only just beginning with C++, I've only ever worked in C nonplusplus (and in no large projects) before, so I don't dare to comment on any C++ code. You'll have to ask someone else about that. |
Just one more thing - please remove the ability to change the sprite of worldmap-spawnpoint. Spawnpoints can't be rendered and setting their sprite just crashes the game. |
Its parent function (to after_editor_set()) already handles all of that properly, so no need to duplicate code.
0266a77
to
9f2f611
Compare
If I remember correctly, it wasn't intentional. |
Fixes #1961
Or rather, should.
Please test this PR to ensure that all objects are indeed fixed.
@HybridDog The rublight's settings builder pulls from grandparent MovingObject instead of parent MovingSprite; was it intended to be that way? It seems like an accident, but I don't want to risk introducing unintended side effects.
Important notes