Zeekling behaviour improvements #2624

MatusGuy · 2023-09-05T12:46:50Z

idea is to make it swoop a bit up then go down, make it feel a bit nicer

Co-authored-by: Tobias Markus <tobbi.bugs@googlemail.com>

MatusGuy · 2023-09-07T15:02:58Z

src/badguy/zeekling.cpp


-  return false;
+  // FIXME: Give the actual object that hit the raycast, or at least the hitbox


In which pull request should this function appear?

@MatusGuy If you have to change a different function to solve this issue, you could do it in another PR and this one would be marked as conditional.

tobbi · 2023-09-07T15:33:38Z

src/badguy/zeekling.cpp

-    // Do not dive if we would not descend faster than the player.
-    float relSpeed = vy - player_mov.y;
-    if (relSpeed <= 0) return false;
+  const Vector& plrmid = get_nearest_player()->get_bbox().get_middle();


That name is not very verbose.

player middle. i thinks its pretty ok. what are your suggestions

player_middle, player_center?

tobbi · 2023-09-07T15:34:19Z

src/badguy/zeekling.cpp

@@ -204,7 +183,7 @@ Zeekling::active_update(float dt_sec) {
      break;
  }

-  BadGuy::active_update(dt_sec);
+    BadGuy::active_update(dt_sec);


Why the indentation?

soz qt creator messed up

mrkubax10 · 2023-09-08T20:02:26Z

Depends on #2631

tobbi · 2023-09-08T20:03:51Z

Can you fixed unused fields?

MatusGuy · 2023-09-08T20:04:25Z

will in the next commit

oopsies

Rusty-Box

Initial review:

Zeekling seems to dive way to early when standing still.

zeekling_dive_too_early.mp4

In some instamces they could clearly dive at me but they don't.

zeekling_no_dive.mp4

Zeekling should not need to dive at Tux when not higher than Tux himself (or below two tiles above the ground). It looks rather goofy

zeekling_same_height.mp4

You can crash the game by doing this:

zeekling_crash.mp4

Also, I personally think that after they reached their lowest diving position they should begin moving back up pretty soon after, if not immidiatly. Right now it takes way too long and makes it look rather stiff and clunky

Rusty-Box · 2023-12-02T17:00:39Z

You can make Zeekling bonk his head weirdly which screws with his recovering and decreases his x-velocity

zeekling_bonk_slow.mp4

MatusGuy · 2023-12-03T14:15:14Z

Thanks for testing rusty, i wouldve never found these on my own.

Zeekling seems to dive way to early when standing still.

My original idea was to not make zeekling as dependant on player velocity, because the old one tried to predict where you were gonna be using the velocity. Looks like the way I'm doing it will require me to find a way to depend on velocity, but this time, control it a bit, and make it not as unfair as the old one.

In some instamces they could clearly dive at me but they don't.

Huh. I'll turn on drawing for the detection line.

Zeekling should not need to dive at Tux when not higher than Tux himself

It does actually do this but it looks like I didn't make it inclusive (doesn't handle same y position)

You can crash the game by doing this

Wtf.

Also, I personally think that after they reached their lowest diving position they should begin moving back up pretty soon after

Alright I'll tweak it later

You can make Zeekling bonk his head weirdly

This is because the red line below the zeekling didn't touch the ground. Looks like I'll have to put it in the edge of the bounding box.

into zeekling_behavior

Rusty-Box · 2024-01-27T16:34:32Z

Damn, I am scratching my head on this one. It is more consisten but at the price of accuracy. I don't know how to approach this issue yet. The only quick thoughts I have been juggling around are:

Drastically decrease the wind-up time and motion between flying and diving.

I feel like this delay between the actual attack had forced us into this weird velocity calcualtion causing to either attack too early or too late. If it could attack faster we might be able to decrease the gap.

Increase the actual diving speed

Controversial but something that might help if it's done carefully, lowering the chances of outrunning Zeekling before it even had a chance to strike

One of the core issues I still see is how easily one could just run past Zeekling without properly engaging. Tight and small platforms shouldn't be the only way to insure that. Even flat ground should leave Zeekling a potential threat

MatusGuy · 2024-01-27T16:56:49Z

Damn, I am scratching my head on this one. It is more consisten but at the price of accuracy

Same.

Drastically decrease the wind-up time and motion between flying and diving.

Could you rephrase this or explain in more detail?

Tight and small platforms shouldn't be the only way to insure that. Even flat ground should leave Zeekling a potential threat.

I think so too. Remind me how you were gonna use zeekling in the new story mode?

Rusty-Box · 2024-01-27T18:50:57Z

Could you rephrase this or explain in more detail?

So right now, I think the time it takes for Zeekling to charg up for their dive and them actually diving down takes way too long which I believe makes it so easy to out run them. This whole "calculating the players walk speed" is trying to work aorund that but to me the core issue should be fixed instead. If that actually fixes it, that is :/

I think so too. Remind me how you were gonna use zeekling in the new story mode?

A mix of both. Zeekling tries to "snipe" you out of the air during platforming thus you must take great care when to do your jumps to not get hit mid-air but also across relatively even stretches of land here and there.

MatusGuy and others added 2 commits September 5, 2023 13:09

code style fix for bump functions

41eff8f

Co-authored-by: Tobias Markus <tobbi.bugs@googlemail.com>

code style polish for zeekling

1037d4e

Co-authored-by: Tobias Markus <tobbi.bugs@googlemail.com>

mrkubax10 added priority:medium status:in-progress Progress has been done, but more is intended be done category:code involves:functionality type:feature labels Sep 5, 2023

MatusGuy added 2 commits September 5, 2023 21:27

swoop up then down (looks rough)

29fcf4e

zeekling raycast detection

8e0a31d

MatusGuy commented Sep 7, 2023

View reviewed changes

tobbi reviewed Sep 7, 2023

View reviewed changes

easing up/down

ae544c8

MatusGuy mentioned this pull request Sep 8, 2023

Raycast function returns what it hit #2631

Merged

mrkubax10 added the status:conditional Needs a requirement to be satisfied before merging. label Sep 8, 2023

MatusGuy added 7 commits September 9, 2023 11:21

remove unused fields

35e9477

forgot to remove them in initializer list

95020a8

oopsies

swoop up depends on animation progress

0b69aa7

Merge branch 'SuperTux:master' into zeekling_behavior

37391e1

Merge branch 'SuperTux:master' into zeekling_behavior

a25356e

Zeek detect player properly

4f0d527

rebounce wip

1713e75

Rusty-Box added this to the 0.7.0 milestone Sep 27, 2023

Rusty-Box added this to In Progress in Rooted Forest Overhaul Sep 27, 2023

MatusGuy added 3 commits November 9, 2023 23:02

Zeekling proper rebound

a2a1123

Zeek recover

434998d

Merge branch 'SuperTux:master' into zeekling_behavior

0304ee8

MatusGuy added 2 commits November 11, 2023 22:58

fix bugs and tweak

e59ec8b

Handle bumping on wall while charging wip

5e23863

MatusGuy self-assigned this Nov 17, 2023

State handling upon bump

11312a6

MatusGuy removed the status:conditional Needs a requirement to be satisfied before merging. label Dec 2, 2023

You have gyatt to be kidding me

97bb941

Rusty-Box reviewed Dec 2, 2023

View reviewed changes

MatusGuy added 10 commits December 3, 2023 16:52

Merge branch 'zeekling_behavior' of https://github.com/MatusGuy/supertux

c6d7055

into zeekling_behavior

Zeekling detection line

9c82746

Rebound detection at edge of hitbox

62035d0

Prevent charging when right next to player

0fd1cee

You have gyatt to be kidding me... again!

56a3d9b

OMFG GIT

e88dd1b

tweak

b90c9df

Merge branch 'SuperTux:master' into zeekling_behavior

ebf5feb

divide player velocity or something like that idk

f54a040

casting

1fafb26

Rusty-Box mentioned this pull request Mar 26, 2024

Remove unnecessary randomness of mole #2847

Merged

MatusGuy added 3 commits May 2, 2024 19:42

Merge branch 'SuperTux:master' into zeekling_behavior

a35d19b

math is so hawwd :3 :3 :3 :3 :3 :3 :3

94023dd

behaviour mostly finished

6b55ea5

MatusGuy force-pushed the zeekling_behavior branch from 94023dd to 0fd1cee Compare June 2, 2024 16:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Zeekling behaviour improvements #2624

Zeekling behaviour improvements #2624

MatusGuy commented Sep 5, 2023

MatusGuy Sep 7, 2023

Vankata453 Sep 7, 2023

tobbi Sep 7, 2023

MatusGuy Sep 7, 2023

Vankata453 Sep 7, 2023

MatusGuy Sep 8, 2023

tobbi Sep 7, 2023

MatusGuy Sep 7, 2023

mrkubax10 commented Sep 8, 2023

tobbi commented Sep 8, 2023

MatusGuy commented Sep 8, 2023

Rusty-Box left a comment

Rusty-Box commented Dec 2, 2023

MatusGuy commented Dec 3, 2023

Rusty-Box commented Jan 27, 2024 •

edited

MatusGuy commented Jan 27, 2024

Rusty-Box commented Jan 27, 2024


		return false;
		// FIXME: Give the actual object that hit the raycast, or at least the hitbox

Zeekling behaviour improvements #2624

Are you sure you want to change the base?

Zeekling behaviour improvements #2624

Conversation

MatusGuy commented Sep 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrkubax10 commented Sep 8, 2023

tobbi commented Sep 8, 2023

MatusGuy commented Sep 8, 2023

Rusty-Box left a comment

Choose a reason for hiding this comment

Rusty-Box commented Dec 2, 2023

MatusGuy commented Dec 3, 2023

Rusty-Box commented Jan 27, 2024 • edited

MatusGuy commented Jan 27, 2024

Rusty-Box commented Jan 27, 2024

Rusty-Box commented Jan 27, 2024 •

edited