Fix badguys not climbing certain slopes #2925
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobbi
force-pushed
the
fix_slope_collisions
branch
from
0850a6b
to
437cc8a
Compare
|
I does kinda work. Only problem is that smart enemies go up all slopes but refuseto go down >=45° slopes. |
This is unrelated and planned to be fixed in #2812 |
MatusGuy
approved these changes
Apr 28, 2024
MatusGuy
added
category:code
status:needs-review
Vankata453
reviewed
May 7, 2024
Comment on lines
198
to
+199
| if ((hit.left && (m_dir == Direction::LEFT)) || (hit.right && (m_dir == Direction::RIGHT))) { | ||
| turn_around(); | ||
| if(hit.slope_normal.x == 0.0f) |
There was a problem hiding this comment.
Can you append this check to the if above (preferably at the beginning, so the hit.left and hit.right checks are done afterwards)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #761
I don't know if this introduces other bugs, so please test this thoroughly before merging.