Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeeklings screech and have curved flight path #697

Closed
wants to merge 2 commits into from
Closed

Zeeklings screech and have curved flight path #697

wants to merge 2 commits into from

Conversation

wbrawner
Copy link

  • Added new screech sound
  • Track Zeekling's and player's positions before diving
  • Modified Zeeklings y velocity on dive based on distance they've moved

I'm not so sure about the math here, so any suggestions on how to improve it would be very welcome. Also, the screech sound came from here: https://opengameart.org/content/15-monster-gruntpaindeath-sounds There's a link there to the publication of the sounds in which the author says the sounds are free to use but he requests attribution: http://cubeengine.com/forum.php4?action=display_thread&thread_id=2164 so I'm not sure if this can be used here or not but I figured I'd give it a shot anyways

* Added new screech sound
* Track Zeekling's and player's positions before diving
* Modified Zeeklings y velocity on dive based on distance they've moved
@mention-bot
Copy link

@wbrawner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tobbi and @Hume2 to be potential reviewers.

@wbrawner
Copy link
Author

This might be the sound designer: http://michel-baradari.de/ could be worth it to contact him and check if he's cool with us using the sound, though we might need a German speaker to do that :D

@maxteufel
Copy link
Member

The CC-BY license as specified on OpenGameArt is perfectly fine and similar to the licenses we use for other stuff. German wouldn't be a problem though.

@tobbi
Copy link
Member

tobbi commented Apr 12, 2017

/Users/travis/build/SuperTux/supertux/src/badguy/zeekling.cpp:197:11: error: unused variable 'distance_to_travel' [-Werror,-Wunused-variable]

      int distance_to_travel = pre_dive_pos.y - pre_dive_player_pos.y;

          ^

1 error generated.

make[2]: *** [CMakeFiles/supertux2_lib.dir/src/badguy/zeekling.cpp.o] Error 1

make[1]: *** [CMakeFiles/supertux2_lib.dir/all] Error 2

make: *** [all] Error 2

@wbrawner
Copy link
Author

Took out the unused variable. Still working on the math for the curve

@tobbi
Copy link
Member

tobbi commented Apr 12, 2017

/home/travis/build/SuperTux/supertux/src/badguy/zeekling.cpp: In constructor ‘Zeekling::Zeekling(const ReaderMapping&)’:

/home/travis/build/SuperTux/supertux/src/badguy/zeekling.cpp:28:1: error: ‘Zeekling::pre_dive_pos’ should be initialized in the member initialization list [-Werror=effc++]

 Zeekling::Zeekling(const ReaderMapping& reader) :

 ^

/home/travis/build/SuperTux/supertux/src/badguy/zeekling.cpp:28:1: error: ‘Zeekling::pre_dive_player_pos’ should be initialized in the member initialization list [-Werror=effc++]

/home/travis/build/SuperTux/supertux/src/badguy/zeekling.cpp: In constructor ‘Zeekling::Zeekling(const Vector&, Direction)’:

/home/travis/build/SuperTux/supertux/src/badguy/zeekling.cpp:40:1: error: ‘Zeekling::pre_dive_pos’ should be initialized in the member initialization list [-Werror=effc++]

 Zeekling::Zeekling(const Vector& pos, Direction d) :

 ^

/home/travis/build/SuperTux/supertux/src/badguy/zeekling.cpp:40:1: error: ‘Zeekling::pre_dive_player_pos’ should be initialized in the member initialization list [-Werror=effc++]

@maxteufel maxteufel added this to Notes and Suggestions in Rooted Forest Overhaul May 1, 2017
@maxteufel maxteufel moved this from Notes and Suggestions to Graphics Improvements in Rooted Forest Overhaul May 1, 2017
@christ2go
Copy link
Contributor

@wbrawner Do you still intend to work on this?

@wbrawner
Copy link
Author

Sorry, I've been pretty absent here. I don't really have the time to work on this any time soon and I haven't since I opened the PR, so I'll just close this for now.

@wbrawner wbrawner closed this May 22, 2019
@Rusty-Box Rusty-Box removed this from Graphics Improvements in Rooted Forest Overhaul Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants