Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling: Fractions for tiles #765

Merged
merged 2 commits into from Jun 19, 2020
Merged

Spelling: Fractions for tiles #765

merged 2 commits into from Jun 19, 2020

Conversation

comradekingu
Copy link
Contributor

No description provided.

@tobbi
Copy link
Member

tobbi commented Feb 11, 2018

Does this work with our font?

@brmbrmcar
Copy link
Contributor

It does not.

@tobbi
Copy link
Member

tobbi commented Feb 13, 2018

Okay, then this depends on our SDL_ttf branch and will be merged when that's ready.

@HybridDog
Copy link
Contributor

As far as I know, it is generally a bad idea to use Unicode characters for text which can be written in ASCII. Non-ASCII characters are often missing in some font files, whereas printable ASCII characters are usually always available.
Furthermore, searching and replacing small pieces of text to make them look slightly better and then reviewing these changes is a waste of time I think.

⅛ is missing in the fonts:
2019-10-11-133347_1920x1080_scrot
2019-10-11-133350_1920x1080_scrot

@HybridDog HybridDog closed this Oct 11, 2019
@comradekingu
Copy link
Contributor Author

@HybridDog Not the biggest deal one way of the other. Generally it is a good idea, that is what they are for. Websafe colours are similarly no longer needed. I think the issue is fixing the font.

@HybridDog HybridDog added the status:needs-work In progress, but no one is currently working on it (New volunteers welcome) label Oct 13, 2019
@HybridDog
Copy link
Contributor

HybridDog commented Oct 13, 2019

I think the issue is fixing the font.

It needs to work with all fonts in which the text may be shown. As long as ⅛ is a just a question mark, this shouldn't be merged.

@busybody42

This comment was marked as off-topic.

@busybody42

This comment was marked as off-topic.

@tobbi
Copy link
Member

tobbi commented Feb 17, 2020

shadow-big-1slash8
white-big-1slash8

That is incredibly hard to read!!

@busybody42

This comment was marked as off-topic.

@HybridDog
Copy link
Contributor

HybridDog commented Feb 18, 2020

I was gonna make a pull request to add in those sprites...

If this PR here should be merged, you also need to add the character to the ttf fonts (maybe with fontforge) or add a fallback functionality to the source code so that letters unknown to the SuperTux font are shown in e.g. dejavu sans mono.

@busybody42

This comment was marked as off-topic.

@slackstone
Copy link
Member

I will personally close this ticket when a $26.00 donation comes into the ST Dev donation queue. There needs to be chocolate involved for a fix like this.

@busybody42 busybody42 mentioned this pull request Feb 25, 2020
@weluvgoatz
Copy link
Member

Seen as no progress has really been made on this for the longest time, I assume it's not going to, and this is an unnecessary feature anyway. The fractions are also very hard to read.

@weluvgoatz weluvgoatz closed this Jun 4, 2020
@comradekingu
Copy link
Contributor Author

comradekingu commented Jun 4, 2020

@weluvgoatz I see, the alternative would be "half tile", "quarter tile" and "half quarter tile", but that isn't as good. Small bigger biggest or "Small", "medium", "big" might work though?

@tobbi
Copy link
Member

tobbi commented Jun 4, 2020

@weluvgoatz I see, the alternative would be "half tile", "quarter tile" and "half quarter tile", but that isn't as good. Small bigger biggest or "Small", "medium", "big" might work though?

That's actually a really good idea in my opinion. Can we do it like this?

@tobbi tobbi reopened this Jun 4, 2020
@comradekingu
Copy link
Contributor Author

@tobbi Edits allowed for maintainers for then one you meant. I prefer the latter, since it is easily understood by kinds (?)

@tobbi
Copy link
Member

tobbi commented Jun 5, 2020

@comradekingu: I meant "Can you do it like this?" obviously.

I also agree with the other sentiment.

@tobbi tobbi merged commit f327c73 into SuperTux:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code status:needs-work In progress, but no one is currently working on it (New volunteers welcome)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants