Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pin position #446

Merged
merged 4 commits into from
Dec 4, 2023
Merged

feat: pin position #446

merged 4 commits into from
Dec 4, 2023

Conversation

carlossantos74
Copy link
Collaborator

@carlossantos74 carlossantos74 commented Nov 30, 2023 •
edited
Loading

canvas-go-to.mp4

@carlossantos74 carlossantos74 marked this pull request as draft November 30, 2023 18:42
@SuperViz-Dev
Copy link
Contributor

Total Coverage: 97.67%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 100% 100% 80.52% 29, 30, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55
src/web-components/base/styles
   icon-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/comments
   comments.ts 92.86% 87.50% 98.23% 44, 45, 61
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-filter.ts 100% 100% 100%
   annotation-item.ts 100% 100% 100%
   annotation-pin.ts 88.89% 100% 100% 35
   annotation-resolved.ts 100% 100% 100%
   annotations.ts 100% 88.89% 90.10% 39, 40, 41, 42, 56, 57, 58, 74, 75, 76
   comment-input.ts 96.55% 94.12% 87.98% 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 57
   comment-item.ts 100% 100% 100%
   content.ts 96% 81.82% 88.71% 104, 105, 35, 36, 39, 40, 41, 47, 48, 49, 63, 74, 75, 76, 77
   delete-comment-modal.ts 100% 100% 100%
   float-button.ts 100% 100% 96.15% 41, 61, 62
   index.ts 100% 100% 100%
   topbar.ts 80% 100% 89.80% 38, 39, 40, 41, 42, 43
   types.ts 100% 100% 100%
src/web-components/comments/css
   annotation-filter.style.ts 100% 100% 100%
   annotation-item.style.ts 100% 100% 100%
   annotation-pin.style.ts 100% 100% 100%
   annotation-resolved.style.ts 100% 100% 100%
   annotations.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   float-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   powered-by.style.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/comments/utils
   watermark.ts 100% 100% 90.77% 17, 18, 19, 20, 21, 22
src/web-components/dropdown
   index.style.ts 100% 100% 100%
   index.ts 85.71% 100% 97.93% 121, 132, 132, 135, 136, 137, 138, 139, 140, 142, 144, 156
   types.ts 100% 100% 100%
src/web-components/hello-world
   index.ts 100% 100% 100%
src/web-components/icon
   index.ts 100% 100% 100%
src/web-components/modal
   index.ts 100% 100% 100%
   modal-container.ts 100% 100% 100%
   modal.ts 100% 100% 100%
src/web-components/modal/styles
   index.style.ts 100% 100% 100%
src/web-components/presence-mouse
   index.ts 71.43% 100% 97.20% 42, 43, 44, 59, 60, 74, 75
   styles.ts 100% 100% 100%
src/web-components/who-is-online
   index.ts 100% 100% 100%
   who-is-online.ts 100% 100% 100%
src/web-components/who-is-online/components
   dropdown.ts 100% 92.31% 100%
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/who-is-online/css
   dropdown.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   who-is-online-style.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 91.00%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   shims.d.ts 100% 100% 100%
src/common
src/common/types
   colors.types.ts 100% 100% 100%
   events.types.ts 100% 100% 100%
   meeting-colors.types.ts 100% 100% 100%
   participant.types.ts 100% 100% 100%
   realtime.types.ts 100% 100% 100%
   sdk-options.types.ts 100% 100% 100%
src/common/utils
   do-request.ts 100% 100% 87.50% 20
   index.ts 100% 100% 100%
   logger.ts 100% 100% 100%
   observable.ts 100% 100% 100%
   observer.ts 100% 100% 100%
   sleep.ts 0% 100% 100% 2
src/components
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/components/base
   index.ts 100% 100% 100%
src/components/comments
   index.ts 92% 97.06% 98.48% 126, 193, 447, 544, 560
   types.ts 100% 100% 100%
src/components/comments/canvas-pin-adapter
   index.ts 69.05% 96.43% 93.75% 230, 230, 230, 230, 231, 232, 235, 297, 298, 300, 300, 300, 302, 302, 303, 305, 306, 309, 311, 366, 370, 383, 426, 471, 485, 486
src/components/presence-mouse
   index.ts 88.89% 83.33% 88.57% 131, 132, 133, 143, 173, 174, 175, 176, 177
src/components/realtime
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/components/video
   index.ts 100% 100% 100%
src/components/who-is-online
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/core
   index.ts 90.91% 100% 90.70% 100, 104, 106, 119, 80, 81
src/core/launcher
   index.ts 93.75% 100% 100% 260
src/services
src/services/api
   index.ts 100% 86.67% 86.54% 104, 105, 106, 107, 94, 95, 97
src/services/auth-service
   index.ts 100% 100% 100%
src/services/browser
   index.ts 100% 100% 100%
src/services/config
   index.ts 100% 100% 100%
src/services/connection-status
   index.ts 100% 100% 100%
src/services/event-bus
   index.ts 100% 100% 100%
src/services/frame-brick-layer
   index.ts 100% 100% 100%
src/services/limits
   index.ts 75% 100% 100% 10
src/services/message-bridge
   index.ts 93.33% 100% 100% 80
src/services/pubsub
   index.ts 100% 90% 100%
src/services/realtime
   index.ts 100% 100% 100%
src/services/realtime/ably
   index.ts 56.36% 60.95% 70.48% 100, 1003, 1004, 104, 1044, 1045, 1056, 1060, 1064, 108, 1100, 1159, 116, 1168, 1170, 1170, 1171, 120, 121, 1269, 1273, 1274, 1275, 1309, 1310, 1314, 1320, 1320, 1321, 1324, 1326, 1327, 1328, 1331, 1335, 1335, 1337, 1338, 1342, 1342, 1342, 1344, 1348, 1350, 1356, 1360, 1361, 1371, 1373, 1379, 1385, 1385, 1386, 1391, 1392, 1395, 1398, 1398, 1399, 1400, 1402, 1403, 1404, 1407, 1411, 1411, 1413, 1414, 1418, 1418, 1418, 1420, 1428, 1428, 1430, 1434, 1434, 1435, 1438, 1440, 1452, 1453, 1463, 1465, 1475, 1477, 1477, 1478, 1481, 194, 279, 420, 422, 432, 445, 458, 458, 460, 502, 512, 513, 534, 535, 537, 538, 540, 540, 541, 555, 557, 560, 562, 572, 573, 574, 575, 576, 576, 577, 578, 590, 600, 602, 604, 606, 607, 607, 613, 613, 613, 613, 613, 614, 616, 618, 621, 621, 621, 621, 621, 622, 624, 625, 625, 625, 625, 625, 626, 627, 627, 627, 627, 627, 628, 629, 629, 630, 630, 630, 630, 635, 637, 640, 642, 642, 642, 642, 643, 645, 673, 674, 684, 726, 727, 756, 758, 759, 760, 760, 761, 764, 771, 771, 772, 772, 774, 774, 774, 777, 778, 781, 781, 782, 783, 786, 787, 789, 794, 894, 894, 895, 898, 900, 900, 900, 901, 903, 957, 959, 960, 962, 964, 966, 966, 966, 966, 967, 968, 969, 972, 973, 976, 979, 979, 979, 979, 980
src/services/realtime/base
   index.ts 100% 100% 100%
src/services/remote-config-service
   index.ts 100% 100% 100%
src/services/video-conference-manager
   index.ts 64.10% 86.11% 93.62% 115, 118, 119, 120, 161, 166, 198, 199, 204, 205, 206, 209, 209, 210, 212, 213, 290, 325, 326, 327, 380, 414, 525, 537, 580, 584
   types.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 97.84%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 100% 100% 80.52% 29, 30, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55
src/web-components/base/styles
   icon-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/comments
   comments.ts 92.86% 87.50% 98.23% 44, 45, 61
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-filter.ts 100% 100% 100%
   annotation-item.ts 100% 100% 100%
   annotation-pin.ts 88.89% 100% 100% 35
   annotation-resolved.ts 100% 100% 100%
   annotations.ts 100% 88.89% 90.10% 39, 40, 41, 42, 56, 57, 58, 74, 75, 76
   comment-input.ts 96.55% 94.12% 87.98% 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 57
   comment-item.ts 100% 100% 100%
   content.ts 96% 81.82% 88.71% 104, 105, 35, 36, 39, 40, 41, 47, 48, 49, 63, 74, 75, 76, 77
   delete-comment-modal.ts 100% 100% 100%
   float-button.ts 100% 100% 96.15% 41, 61, 62
   index.ts 100% 100% 100%
   topbar.ts 80% 100% 89.80% 38, 39, 40, 41, 42, 43
   types.ts 100% 100% 100%
src/web-components/comments/css
   annotation-filter.style.ts 100% 100% 100%
   annotation-item.style.ts 100% 100% 100%
   annotation-pin.style.ts 100% 100% 100%
   annotation-resolved.style.ts 100% 100% 100%
   annotations.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   float-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   powered-by.style.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/comments/utils
   watermark.ts 100% 100% 90.77% 17, 18, 19, 20, 21, 22
src/web-components/dropdown
   index.style.ts 100% 100% 100%
   index.ts 99.17% 100% 100% 368
   types.ts 100% 100% 100%
src/web-components/hello-world
   index.ts 100% 100% 100%
src/web-components/icon
   index.ts 100% 100% 100%
src/web-components/modal
   index.ts 100% 100% 100%
   modal-container.ts 100% 100% 100%
   modal.ts 100% 100% 100%
src/web-components/modal/styles
   index.style.ts 100% 100% 100%
src/web-components/presence-mouse
   index.ts 71.43% 100% 97.20% 42, 43, 44, 59, 60, 74, 75
   styles.ts 100% 100% 100%
src/web-components/who-is-online
   index.ts 100% 100% 100%
   who-is-online.ts 97.22% 100% 99.47% 113, 114
src/web-components/who-is-online/components
   dropdown.ts 98.44% 95% 98.44% 100, 101, 102, 103, 104, 99
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/who-is-online/css
   dropdown.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   who-is-online-style.ts 100% 100% 100%

Raspincel
Raspincel approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Raspincel Raspincel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@carlossantos74 carlossantos74 marked this pull request as ready for review December 4, 2023 11:48
@carlossantos74 carlossantos74 merged commit b16d6de into lab Dec 4, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 4, 2023
@carlossantos74
BUILD: (b16d6de) Merge pull request #446 from SuperViz/feat/pin-place…
fe17fdd 
…ment

feat: pin position
@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsovinicius afonsovinicius afonsovinicius approved these changes

@Raspincel Raspincel Raspincel approved these changes

@vitorvargasdev vitorvargasdev Awaiting requested review from vitorvargasdev

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossantos74 @SuperViz-Dev @afonsovinicius @Raspincel