Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve comment animation #602

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

Raspincel
Copy link
Contributor

No description provided.

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 93.16%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   shims.d.ts 100% 100% 100%
src/common
src/common/types
   colors.types.ts 100% 100% 100%
   events.types.ts 100% 100% 100%
   meeting-colors.types.ts 100% 100% 100%
   participant.types.ts 100% 100% 100%
   realtime.types.ts 100% 100% 100%
   sdk-options.types.ts 100% 100% 100%
src/common/utils
   do-request.ts 100% 100% 87.50% 20
   index.ts 100% 100% 100%
   logger.ts 100% 100% 100%
   observable.ts 100% 100% 100%
   observer.ts 100% 100% 100%
   sleep.ts 0% 100% 100% 2
src/components
   index.ts 100% 85.71% 100%
   types.ts 100% 100% 100%
src/components/base
   index.ts 100% 100% 100%
src/components/comments
   index.ts 94.44% 93.18% 96.33% 236, 295, 354, 355, 356, 358, 476, 514, 583, 696, 712
   types.ts 100% 100% 100%
src/components/comments/canvas-pin-adapter
   index.ts 57.63% 85.71% 87.50% 205, 206, 207, 254, 254, 254, 254, 255, 256, 259, 259, 260, 263, 333, 334, 336, 336, 336, 338, 338, 339, 341, 342, 345, 347, 396, 397, 398, 417, 428, 439, 443, 456, 477, 502, 522, 523, 534, 535, 536, 537, 538, 538, 538, 538, 538, 540, 540, 541, 541, 541, 541, 545, 547, 548
src/components/comments/html-pin-adapter
   index.ts 91.89% 98.28% 96.61% 284, 285, 286, 372, 481, 482, 503, 504, 506, 506, 508, 509, 511, 511, 511, 511, 513, 514, 729, 730, 731, 808, 809, 810
src/components/presence-mouse
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/components/presence-mouse/canvas
   index.ts 80.65% 95.45% 99.38% 210, 210, 210, 210, 280, 290, 369
src/components/presence-mouse/html
   index.ts 94.59% 100% 100% 505, 620
src/components/realtime
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/components/video
   index.ts 92.73% 98.08% 98.26% 211, 507, 635, 740, 740, 743, 743, 745
src/components/who-is-online
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/core
   index.ts 86.96% 57.14% 76% 114, 117, 121, 122, 124, 137, 139, 145, 69, 69, 71, 72, 73, 93, 94
src/core/launcher
   index.ts 94.12% 95.45% 98.64% 283, 95, 99
src/services
src/services/api
   index.ts 100% 88.24% 88.33% 102, 103, 105, 111, 112, 113, 114
src/services/auth-service
   index.ts 100% 100% 100%
src/services/browser
   index.ts 100% 100% 100%
src/services/config
   index.ts 100% 100% 100%
src/services/connection-status
   index.ts 100% 100% 100%
src/services/event-bus
   index.ts 100% 100% 100%
src/services/frame-brick-layer
   index.ts 100% 100% 100%
src/services/limits
   index.ts 75% 100% 100% 10
src/services/message-bridge
   index.ts 93.33% 100% 100% 80
src/services/pubsub
   index.ts 100% 90% 100%
src/services/realtime
   index.ts 100% 100% 100%
src/services/realtime/ably
   index.ts 65.04% 61.32% 72.13% 101, 1014, 105, 109, 1103, 1107, 1108, 1109, 1143, 1144, 1148, 1154, 1154, 1155, 1158, 1160, 1161, 1162, 1165, 1169, 1169, 117, 1171, 1172, 1176, 1176, 1176, 1178, 1182, 1184, 1190, 1194, 1195, 1205, 1207, 121, 1213, 122, 1230, 1230, 1232, 1233, 1234, 1265, 1265, 1266, 1271, 1272, 1275, 1278, 1278, 1279, 1280, 1282, 1283, 1284, 1287, 1291, 1291, 1293, 1294, 1298, 1298, 1298, 1298, 1300, 1300, 1300, 1302, 1310, 1310, 1312, 1316, 1316, 1317, 1320, 1322, 1334, 1335, 1345, 1347, 1357, 1359, 1359, 1360, 1363, 194, 260, 270, 411, 413, 414, 427, 440, 440, 442, 454, 455, 456, 507, 508, 510, 511, 513, 513, 514, 528, 530, 533, 535, 545, 546, 547, 548, 549, 549, 550, 551, 563, 565, 575, 577, 579, 581, 581, 581, 581, 582, 584, 601, 602, 612, 613, 623, 665, 666, 777, 777, 778, 781, 783, 783, 783, 784, 786, 839, 841, 842, 843, 843, 844, 845, 848, 849, 849, 851, 851, 854, 858, 858, 859, 863, 864, 867, 88, 881, 883, 884, 905, 905, 906, 909, 913, 914, 916, 917, 917, 919, 954
src/services/realtime/base
   index.ts 100% 100% 100%
src/services/remote-config-service
   index.ts 100% 100% 100%
src/services/video-conference-manager
   index.ts 61.90% 84.21% 93.53% 121, 124, 125, 126, 169, 174, 206, 207, 212, 213, 214, 217, 217, 218, 220, 221, 299, 311, 333, 360, 361, 362, 415, 449, 560, 572, 615, 619, 678
   types.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 97.53%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 100% 100% 80.52% 29, 30, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55
src/web-components/base/styles
   icon-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/base/utils
   importStyle.ts 66.67% 100% 100% 3
src/web-components/comments
   comments.ts 88.24% 76.92% 87.65% 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 135, 64, 65, 66, 79, 80, 92, 93, 94, 95, 96, 97
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-filter.ts 100% 100% 100%
   annotation-item.ts 100% 96.43% 96.73% 181, 182, 183, 184, 185, 186, 187, 188, 232, 233
   annotation-pin.ts 100% 100% 95.06% 117, 122, 123, 124, 125, 176, 177, 178, 73, 74, 75, 76, 77
   annotation-resolved.ts 100% 100% 100%
   comment-input.ts 100% 96.55% 97.63% 221, 222, 223, 226, 227, 255, 256, 353, 354, 368, 369
   comment-item.ts 100% 100% 100%
   content.ts 96.15% 81.82% 89.15% 108, 109, 39, 40, 43, 44, 45, 51, 52, 53, 67, 78, 79, 80, 81
   delete-comment-modal.ts 100% 100% 100%
   float-button.ts 100% 100% 87.65% 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 50, 51, 55, 56, 72, 81
   index.ts 100% 100% 100%
   mention-list.ts 100% 100% 100%
   topbar.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/comments/css
   annotation-filter.style.ts 100% 100% 100%
   annotation-item.style.ts 100% 100% 100%
   annotation-pin.style.ts 100% 100% 100%
   annotation-resolved.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   float-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   mention-list.style.ts 100% 100% 100%
   powered-by.style.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/comments/utils
   autocomplete-handler.ts 100% 100% 98.29% 25, 26
   mention-handler.ts 100% 100% 100%
   watermark.ts 100% 100% 86.15% 15, 16, 17, 18, 19, 20, 21, 22, 23
src/web-components/dropdown
   index.style.ts 100% 100% 100%
   index.ts 92.73% 100% 97.60% 154, 155, 156, 157, 158, 159, 187, 221, 251, 83, 86
src/web-components/hello-world
   index.ts 100% 100% 100%
src/web-components/icon
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/modal
   index.ts 100% 100% 100%
   modal-container.ts 100% 100% 100%
   modal.ts 100% 100% 100%
src/web-components/modal/styles
   index.style.ts 100% 100% 100%
src/web-components/tooltip
   index.style.ts 100% 100% 100%
   index.ts 85.19% 100% 95.15% 109, 110, 111, 112, 114, 115, 116, 117, 152, 156, 221, 222, 223, 224, 88, 90, 91, 92, 94, 95, 96
   types.ts 100% 100% 100%
src/web-components/who-is-online
   index.ts 100% 100% 100%
   who-is-online.ts 94% 100% 97.88% 148, 149, 150, 160, 161, 162, 178, 179, 180, 316, 316, 316, 317, 318
src/web-components/who-is-online/components
   dropdown.ts 91.67% 94.74% 97.34% 133, 134, 135, 136, 137, 138, 170, 170, 182, 182, 183, 184
   index.ts 100% 100% 100%
   messages.ts 100% 78.57% 97.12% 114, 115, 123, 124, 132, 133
   types.ts 100% 100% 100%
src/web-components/who-is-online/css
   dropdown.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   messages.style.ts 100% 100% 100%
   who-is-online-style.ts 100% 100% 100%

@Raspincel Raspincel changed the title Fix/resolve comment animation fix: resolve comment animation Mar 14, 2024
@carlossantos74 carlossantos74 merged commit 4555022 into lab Mar 14, 2024
4 checks passed
@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 5.8.0-lab.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 5.8.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 5.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants