Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: using google/cloud-storage. #75

Merged
merged 8 commits into from
Feb 7, 2018

Conversation

sinkcup
Copy link
Contributor

@sinkcup sinkcup commented Feb 5, 2018

#74

@zoidyzoidzoid
Copy link
Contributor

zoidyzoidzoid commented Feb 7, 2018

0.21 of google/cloud goes back to the 22nd of February 2017, while 1.3.0 of google/cloud-storage only goes back to the 15th of December 2017. Even 1.0.0 only goes back to March 2017.

We should maybe try support from 1.0.0 onwards, and test each latest minor version at least, and there aren't too many so we can just add them to the env matrix in .travis.yml?

@sinkcup
Copy link
Contributor Author

sinkcup commented Feb 7, 2018

@zoidbergwill good idea! I have changed it.

composer.json Outdated
@@ -11,7 +11,7 @@
"require": {
"php": ">=5.5.0",
"league/flysystem": "~1.0",
"google/cloud": ">=0.21 <0.50"
"google/cloud-storage": "^1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do>= 1.0 <1.4, because it is safer.

@sinkcup
Copy link
Contributor Author

sinkcup commented Feb 7, 2018

fine, I have changed it again.

Copy link
Contributor

@zoidyzoidzoid zoidyzoidzoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks. 👍

@zoidyzoidzoid zoidyzoidzoid merged commit be84763 into Superbalist:master Feb 7, 2018
@sinkcup sinkcup deleted the issue-74 branch February 7, 2018 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants