Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: SP-272 - Editor doesn't catch first input from user #23

Closed
wants to merge 2 commits into from

Conversation

Spejbl
Copy link
Contributor

@Spejbl Spejbl commented Oct 21, 2019

Description of the Change

When user opens a file for a first time and types any character, file editor doesn't gets updated until second try. Same applies when deleting character. This PR should resolve such problem.

Copy link
Contributor

@filippsen filippsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code: unclear why changing the code assignment in value property relates to this.


Another example is when selecting all contents from the file and typing in random data. Content gets added at the beginning of the selection instead of replacing the selection.

Steps to reproduce the original issue:

  • Select Template -> Hello World
  • Press Create Project
  • Select any text from README
  • Copy the contents with Ctrl/Cmd+C
  • Select any line inside the same README file
  • Paste the contents with Ctrl/Cmd+V

Before this request, editor copy and paste using shortcuts would work (sometimes), but only after setting focus (unclear if that is always on second try).
With this change it always works on first try.


There is one side-effect situation which started to happen now when an unsaved file tab is open and the Copy and Paste (or any other action) wouldn't get processed on another (different) tab.

Steps to reproduce:

  • Edit a file (e.g. HelloWorld.sol) and leave it unsaved (verify: red Save icon)
  • Open README.md from the Explorer
  • Select any text from the README
  • Copy with Ctrl/Cmd+C
  • Select any line inside the same file
  • Try to paste with Ctrl/Cmd+V
  • Observe no feedback (from any shortcut, command or keystroke)

@bashlund bashlund added this to To do in Release-1 Oct 30, 2019
@javier-tarazaga javier-tarazaga moved this from To do to Review in progress in Release-1 Nov 4, 2019
@Spejbl
Copy link
Contributor Author

Spejbl commented Nov 6, 2019

I'm unable to reproduce this issue on Live environment, so this PR might be obsolete.

@javier-tarazaga
Copy link
Contributor

javier-tarazaga commented Nov 6, 2019

@Spejbl if that is the case then let's close the issue. Btw I tried to reproduce the issue in the Live env and I couldn't manage either.

Release-1 automation moved this from Review in progress to Done Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Release-1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants