Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let elixir handle protocol consolidation #17

Closed
wants to merge 1 commit into from
Closed

Let elixir handle protocol consolidation #17

wants to merge 1 commit into from

Conversation

starbelly
Copy link
Contributor

It seems as though we can simply let elixir and friends handle protocol consolidation which resolves issue(s) in pulling in deps such as Jason, Decimal, etc.

1> 'Elixir.Jason':encode('Elixir.Decimal':new(<<"1.0">>)).
{ok,<<"\"1.0\"">>}
2>

It may be there is a piece to the puzzle here I'm not understanding about protocols and releases and why it needs to be handled the way it is. If this is not the case, I'll happily add a test case to go along with this change.

- Removed rebar_mix_hook.erl and src/rebar_mix_protocol_consolidation.exs
@tsloughter
Copy link
Collaborator

@starbelly as far as I know this is not consolidating the protocols so is not what anyone would want to use in production. It technically works, but is slow.

@starbelly
Copy link
Contributor Author

Closing this per misunderstanding of protocol consolidation on my end.

@starbelly starbelly closed this May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants