Fix rebar3 release #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"rebar3 shell" command is failing because of ERL_FLAGS being set in "hooks" related code, where it is not needed. So, wrote a custom sh() function which resets ERL_FLAGS to [] before doing whatever, sh() wanted to do.
`release` build under rebar3 does not process any provider hooks, and hence some configuration like the following would not call rebar_mix provider to be able to inject elixir libraries.
{provider_hooks, [
{pre, [{compile, {mix, find_elixir_libs}}]}, => callbacks during 'compile' phase get called
{pre, [{release, {mix, find_elixir_libs}}]} => This will not callback find_elixir_libs
]}.
Given this, `relx` configuration in `rebar_state` needs to be updated with Elixir lib_dirs. This can be done from `rebar_mix` module as part of init callback. This solution does that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
releasebuild under rebar3 does not process any provider hooks, and hence some configuration like the following would not call rebar_mix provider to be able to inject elixir libraries.{provider_hooks, [
{pre, [{compile, {mix, find_elixir_libs}}]}, => callbacks during 'compile' phase get called
{pre, [{release, {mix, find_elixir_libs}}]} => This will not callback find_elixir_libs
]}.
Given this,
relxconfiguration inrebar_stateneeds to be updated with Elixir lib_dirs. This can be done fromrebar_mixmodule as part of init callback. This solution does that.