Publish to Chrome Webstore and Mozilla Addons #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikBjare
commented
Jun 27, 2018
.travis.yml
Outdated
| @@ -3,7 +3,7 @@ node_js: | |||
| - "8" | |||
|
|
|||
| install: | |||
| - make install | |||
| - npm install | |||
There was a problem hiding this comment.
@Powersource Why did you change this? Changing it back.
Powersource
reviewed
Jun 27, 2018
Makefile
Outdated
| # https://www.npmjs.com/package/firefox-extension-deploy | ||
| node scripts/publish-mozilla-addons.sh | ||
| # Doing it like this would expose keys, not acceptable | ||
| # webstore upload --source extension.zip --extension-id ${WEBSTORE_EXTENSION_ID} --client-id ${WEBSTORE_CLIENT_ID} --client-secret ${WEBSTORE_CLIENT_SECRET} --refresh-token ${REFRESH_TOKEN} |
There was a problem hiding this comment.
Webstore by default gets these from envvars, you don't have to specify it.
And shouldn't we be safe by putting them as secret envvars in travis?
There was a problem hiding this comment.
Yeah, the only issue is that we'd want to name them something different in the envvars as they might otherwise conflict.
ahnlabb
reviewed
Jun 27, 2018
Makefile
Outdated
| # Use these to automatically publish | ||
| # https://www.npmjs.com/package/chrome-webstore-upload-cli | ||
| # https://www.npmjs.com/package/firefox-extension-deploy | ||
| node scripts/publish-mozilla-addons.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #30
Automatic deployment on tagged releases will be done in a later PR, see #33