-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/ui vuetify #62
Dev/ui vuetify #62
Conversation
…to dev/ui-vuetify
src/dashboard/DashboardPage.vue
Outdated
| Distribute | ||
v-layout(row, wrap) | ||
v-flex(xs6) | ||
v-alert(v-for="error in errors", show, dismissible, variant='warning', @dismissed='dismissedErrors++') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variant
remaining
td.text-xs-right | ||
| {{props.item.usdAmount}} $ | ||
div.text-xs-center.pt-2 | ||
v-btn(v-if="to", variant="outline-secondary", size="sm", :to="to") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variant
remaining
src/dashboard/ActivityComponent.vue
Outdated
td.text-right | ||
| {{ props.item.duration | friendlyDuration }} | ||
div.text-xs-center.pt-2 | ||
v-btn(v-if="to", variant="outline-secondary", size="sm", :to="to") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variant
remaining
src/dashboard/App.vue
Outdated
div.row | ||
div.col | ||
hr | ||
| We're still figuring things out. Please report any issues to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add URL to GitHub issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wrapper width (or something like it) is too wide in Firefox.
Also two compile warnings now. Should fix them and maybe make the build error on those warnings instead.
Most added promises aren't caught on errors.
src/dashboard/ActivityComponent.vue
Outdated
v-data-table(:headers="headers", :items="activities", :pagination.sync='pagination', hide-actions) | ||
template(slot='items', slot-scope='props') | ||
td | ||
a(:href="props.item.url") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target="_blank"
v-data-table(:headers="headers", :items="donations", :pagination.sync='pagination', hide-actions) | ||
template(slot='items', slot-scope='props') | ||
td | ||
a(:href="'https://ropsten.etherscan.io/tx/' + props.item.transaction" target="_blank") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe for another PR, but this doesn't link correctly for mainnet transactions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made an issue: #65
src/dashboard/App.vue
Outdated
a(href="#/") | ||
h1 Thankful Dashboard | ||
div.pl-3 | ||
h1 #[a(href="#/") Thankful Dashboard] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use router-link
src/dashboard/DashboardPage.vue
Outdated
@@ -42,7 +42,7 @@ div | |||
| No creators to show | |||
|
|||
v-layout(row, wrap) | |||
v-flex(v-for="(creator, index) in creators", xs12, sm6, md3) | |||
v-flex(v-for="(creator, index) in creators", :key='creator.url', xs13, sm6, md3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xs13
? 😮
@@ -12,7 +12,7 @@ div | |||
td.text-xs-right | |||
| {{props.item.usdAmount}} $ | |||
div.text-xs-center.pt-2 | |||
v-btn(v-if="to", variant="outline-secondary", size="sm", :to="to") | |||
v-btn(v-if="to", size="sm", :to="to") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why :to="to"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now, merging!
No description provided.