Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/ui vuetify #62

Merged
merged 11 commits into from
Jul 9, 2018
Merged

Dev/ui vuetify #62

merged 11 commits into from
Jul 9, 2018

Conversation

ahnlabb
Copy link
Contributor

@ahnlabb ahnlabb commented Jul 9, 2018

No description provided.

| Distribute
v-layout(row, wrap)
v-flex(xs6)
v-alert(v-for="error in errors", show, dismissible, variant='warning', @dismissed='dismissedErrors++')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variant remaining

td.text-xs-right
| {{props.item.usdAmount}} $
div.text-xs-center.pt-2
v-btn(v-if="to", variant="outline-secondary", size="sm", :to="to")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variant remaining

td.text-right
| {{ props.item.duration | friendlyDuration }}
div.text-xs-center.pt-2
v-btn(v-if="to", variant="outline-secondary", size="sm", :to="to")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variant remaining

div.row
div.col
hr
| We're still figuring things out. Please report any issues to.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add URL to GitHub issues

Copy link
Member

@Powersource Powersource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wrapper width (or something like it) is too wide in Firefox.

Also two compile warnings now. Should fix them and maybe make the build error on those warnings instead.

Most added promises aren't caught on errors.

v-data-table(:headers="headers", :items="activities", :pagination.sync='pagination', hide-actions)
template(slot='items', slot-scope='props')
td
a(:href="props.item.url")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target="_blank"

v-data-table(:headers="headers", :items="donations", :pagination.sync='pagination', hide-actions)
template(slot='items', slot-scope='props')
td
a(:href="'https://ropsten.etherscan.io/tx/' + props.item.transaction" target="_blank")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for another PR, but this doesn't link correctly for mainnet transactions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made an issue: #65

a(href="#/")
h1 Thankful Dashboard
div.pl-3
h1 #[a(href="#/") Thankful Dashboard]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -42,7 +42,7 @@ div
| No creators to show

v-layout(row, wrap)
v-flex(v-for="(creator, index) in creators", xs12, sm6, md3)
v-flex(v-for="(creator, index) in creators", :key='creator.url', xs13, sm6, md3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xs13? 😮

@@ -12,7 +12,7 @@ div
td.text-xs-right
| {{props.item.usdAmount}} $
div.text-xs-center.pt-2
v-btn(v-if="to", variant="outline-secondary", size="sm", :to="to")
v-btn(v-if="to", size="sm", :to="to")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why :to="to"?

Copy link
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now, merging!

@ErikBjare ErikBjare merged commit a34fff6 into master Jul 9, 2018
@ErikBjare ErikBjare deleted the dev/ui-vuetify branch July 9, 2018 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants