Support HTTP Basic Authentication for httpok checks #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix settimeout for https (was raising NoneType has no attribute settimeout) See maxnaude@2bf7498 Fix args for authentication Move headers creation outside of retry loop since the headers stay the same
|
Thanks for the pull request. This feature looks good but we need test coverage for it. If you would be willing to write some tests, we can probably merge this. Please remove the unrelated settimeout fix. It should be merged separately to keep the history clean. |
|
Hi @mnaberez! Great to meet you. Sure, I can do that. Will update this PR soon. Thanks for your work on this project - saved us a ton of time. Hope your day's going well! |
mnaberez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are checking an endpoint that we have basic authentication on with
httpokand figured this might be useful for others as well:username:passwordstring for basic authentication(Same fix as maxnaude@2bf7498)
Let me know if there are any tests that should be written for this.