Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.8.1 supporting factorio 1.1.1 #9

Merged
merged 1 commit into from Dec 1, 2020
Merged

v1.8.1 supporting factorio 1.1.1 #9

merged 1 commit into from Dec 1, 2020

Conversation

voidus
Copy link
Contributor

@voidus voidus commented Nov 26, 2020

I started a game, placed some steam engines and everything seems to work. I'm not sure if there are any more tests I can/should run.

@MrTyton
Copy link

MrTyton commented Nov 28, 2020

+1

@Zomis
Copy link

Zomis commented Nov 29, 2020

The other versions have been 1.x.0, maybe this should be too?

I should maybe have looked for other pull requests before I created my own :D

@voidus
Copy link
Contributor Author

voidus commented Nov 30, 2020

I don't know about 1.1.0, I feel it suggests that the mod only works with that specific patch version? 1.1 works though.

@Zomis
Copy link

Zomis commented Nov 30, 2020

I don't know about 1.1.0, I feel it suggests that the mod only works with that specific patch version? 1.1 works though.

@voidus I mean that this mod has been doing a 1.x.0 release whenever a new version of Factorio is out, so I'm guessing the author might want a 1.9.0 instead of 1.8.1.

But yes, I have also verified that this mod work just fine with both Factorio 1.0 and 1.1.

@voidus
Copy link
Contributor Author

voidus commented Nov 30, 2020

Ah, yeah, I misunderstood that. @Suprcheese if you want the bump, let me know and I'll update it :)

@Suprcheese Suprcheese merged commit a6da70a into Suprcheese:master Dec 1, 2020
@Suprcheese
Copy link
Owner

Back from vacation, thanks everyone for checking that it still works with the current version. I'll push the update out shortly.

@Suprcheese Suprcheese mentioned this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants