Add pyteamcity.future to packages #83
Conversation
|
@aconrad This looks good, but I can't merge it, I think because I removed myself from the SurveyMonkey org. Want to add me back or merge it? |
|
@msabramo someone removed me from the SurveyMonkey org, but then I became a collaborator which retained my rights and permissions. I just added you as a collaborator, let me know if it works for you. |
|
Also, do you care about my comment? |
|
Hmmm, I still don't see a merge button. Oh did you comment on this? I don't see a comment. Or did you mean that you have an opinion on this that you haven't voiced yet? In either case, I definitely want to hear if you have any opinions! |
setup.py
Outdated
| @@ -25,7 +25,7 @@ def read(fname): | |||
| maintainer_email='marc@marc-abramowitz.com', | |||
| author='Yotam Oron', | |||
| author_email='yotamoron@yahoo.com', | |||
| packages=['pyteamcity', 'pyteamcity.legacy'], | |||
| packages=['pyteamcity', 'pyteamcity.legacy', 'pyteamcity.future', 'pyteamcity.future.core'], | |||
There was a problem hiding this comment.
Wouldn't it be better to use setuptool's find_packages() utility to avoid having to maintain that list every time a sub-package is added?
https://setuptools.readthedocs.io/en/latest/setuptools.html#using-find-packages
There was a problem hiding this comment.
That's a great idea. Let me do that.
There was a problem hiding this comment.
Yeah, that is a good idea!
|
I created a review, but I think it was "pending". Never used the "start a review" feature of Github yet. |
|
I checked, it seems that you need to accept the invite to become a collaborator. |
|
@msabramo you have to follow this link: https://github.com/SurveyMonkey/pyteamcity/invitations |
This is so that we can install and use
pyteamcity.futureusing pip:while waiting for the new API to be officially released (#70)