Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pyteamcity.future to packages #83

Merged
merged 3 commits into from Feb 18, 2017
Merged

Add pyteamcity.future to packages #83

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a42b298
Add pyteamcity.future to packages
baopham Feb 12, 2017
4e2c479
Add pyteamcity.future.core to packages
baopham Feb 12, 2017
f2a4c59
Use setuptools find_packages()
baopham Feb 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Expand Up @@ -25,7 +25,7 @@ def read(fname):
maintainer_email='marc@marc-abramowitz.com',
author='Yotam Oron',
author_email='yotamoron@yahoo.com',
packages=['pyteamcity', 'pyteamcity.legacy'],
packages=['pyteamcity', 'pyteamcity.legacy', 'pyteamcity.future', 'pyteamcity.future.core'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to use setuptool's find_packages() utility to avoid having to maintain that list every time a sub-package is added?

https://setuptools.readthedocs.io/en/latest/setuptools.html#using-find-packages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great idea. Let me do that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that is a good idea!

zip_safe=False,
install_requires=[
'beautifulsoup4',
Expand Down