Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure news and tweets are not null, fixes #119 #137

Merged
merged 1 commit into from Nov 10, 2018
Merged

Conversation

zyuiop
Copy link
Collaborator

@zyuiop zyuiop commented Nov 9, 2018

No description provided.

@codeclimate
Copy link

codeclimate bot commented Nov 9, 2018

Code Climate has analyzed commit f6aaac6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (75% is the threshold).

This pull request will bring the total coverage in the repository to 85.5% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@Luminilion Luminilion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However I would suggest renaming NewsOrTweets to something like NewsAllTypes for coherence in order to include Facebook or such news later on.

@zyuiop zyuiop merged commit 05709fa into master Nov 10, 2018
@zyuiop zyuiop deleted the bugfix/119-npe-news branch November 10, 2018 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants