Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/overwriting settings with comments with extension variables #95

Conversation

schroda
Copy link
Contributor

@schroda schroda commented Mar 4, 2024

No description provided.

@schroda schroda marked this pull request as draft March 4, 2024 19:21
@schroda schroda force-pushed the fix/overwriting_settings_with_comments_with_extension_variables branch from 207c92e to 2be666a Compare March 4, 2024 19:35
@schroda schroda marked this pull request as ready for review March 4, 2024 19:35
@schroda schroda force-pushed the fix/overwriting_settings_with_comments_with_extension_variables branch 2 times, most recently from 3049209 to 10afb0c Compare March 10, 2024 18:11
@schroda schroda marked this pull request as draft March 10, 2024 18:11
@schroda schroda force-pushed the fix/overwriting_settings_with_comments_with_extension_variables branch 12 times, most recently from 3b31cac to 9b9f619 Compare March 10, 2024 20:00
Comments were either removed or broke the setting value due to incorrect formatting
Due to the "-rm" option when starting the container, it was immediately deleted after it was stopped.
This prevented the workflow from getting the containers logs since it didn't exist anymore at this point of time and instead an error was raised
@schroda schroda force-pushed the fix/overwriting_settings_with_comments_with_extension_variables branch 3 times, most recently from bd124c7 to 3d85ecd Compare March 10, 2024 23:12
@schroda schroda force-pushed the fix/overwriting_settings_with_comments_with_extension_variables branch from 3d85ecd to 7a59b49 Compare March 10, 2024 23:15
@schroda schroda marked this pull request as ready for review March 10, 2024 23:18
@Syer10 Syer10 merged commit 7b672f8 into Suwayomi:main Mar 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants