Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/overwriting settings with comments with extension variables #95

Merged
merged 5 commits into from
Mar 10, 2024
Merged

Fix/overwriting settings with comments with extension variables #95

merged 5 commits into from
Mar 10, 2024

Commits on Mar 10, 2024

  1. Overwrite config settings with comments correctly 

    Comments were either removed or broke the setting value due to incorrect formatting
    @schroda
    schroda committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    ba91890 View commit details
    Browse the repository at this point in the history

  2. Fix "webUIEnabled" env var name

    @schroda
    schroda committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    27c8701 View commit details
    Browse the repository at this point in the history

  3. Delete container only after receiving its logs 

    Due to the "-rm" option when starting the container, it was immediately deleted after it was stopped.
This prevented the workflow from getting the containers logs since it didn't exist anymore at this point of time and instead an error was raised
    @schroda
    schroda committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    d50e3f9 View commit details
    Browse the repository at this point in the history

  4. Print container logs in case of failure

    @schroda
    schroda committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    14e0bc4 View commit details
    Browse the repository at this point in the history

  5. Add a workflow step to test the container with passing env vars

    @schroda
    schroda committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    7a59b49 View commit details
    Browse the repository at this point in the history