Removed few lint warnings; [Release]increased version code;

Swati4star · Jun 6, 2018 · 4ebc2fa · 4ebc2fa
1 parent 22b7cbe
commit 4ebc2fa
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 12 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -9,8 +9,8 @@ android {
         vectorDrawables.useSupportLibrary = true
         minSdkVersion 19
         targetSdkVersion 27
-        versionCode 6
-        versionName "2.3"
+        versionCode 8
+        versionName "2.5"
     }
     buildTypes {
         release {

diff --git a/app/src/main/java/swati4star/createpdf/adapter/ViewFilesAdapter.java b/app/src/main/java/swati4star/createpdf/adapter/ViewFilesAdapter.java
@@ -41,7 +41,6 @@
 import butterknife.BindView;
 import butterknife.ButterKnife;
 import swati4star.createpdf.R;
-import swati4star.createpdf.fragment.ViewFilesFragment;
 
 
 /**

diff --git a/app/src/main/java/swati4star/createpdf/fragment/ViewFilesFragment.java b/app/src/main/java/swati4star/createpdf/fragment/ViewFilesFragment.java
@@ -46,7 +46,7 @@ public class ViewFilesFragment extends Fragment
     private static final int SIZE_INCREASING_ORDER_INDEX = 2;
     private static final int SIZE_DECREASING_ORDER_INDEX = 3;
     private Activity mActivity;
-    ViewFilesAdapter mViewFilesAdapter;
+    private ViewFilesAdapter mViewFilesAdapter;
     @BindView(R.id.filesRecyclerView)
     RecyclerView mViewFilesListRecyclerView;
     @BindView(R.id.swipe)
@@ -310,14 +310,19 @@ private void populateListView() {
                 pdfFiles = getPdfsFromPdfFolder();
             }
             Log.v("done", "adding");
-            if (mCurrentSortingIndex == NAME_INDEX) {
-                sortByNameAlphabetical(pdfFiles);
-            } else if (mCurrentSortingIndex == DATE_INDEX) {
-                sortFilesByDateNewestToOldest(pdfFiles);
-            } else if (mCurrentSortingIndex == SIZE_INCREASING_ORDER_INDEX) {
-                sortFilesBySizeIncreasingOrder(pdfFiles);
-            } else if (mCurrentSortingIndex == SIZE_DECREASING_ORDER_INDEX) {
-                sortFilesBySizeDecreasingOrder(pdfFiles);
+            switch (mCurrentSortingIndex) {
+                case NAME_INDEX:
+                    sortByNameAlphabetical(pdfFiles);
+                    break;
+                case DATE_INDEX:
+                    sortFilesByDateNewestToOldest(pdfFiles);
+                    break;
+                case SIZE_INCREASING_ORDER_INDEX:
+                    sortFilesBySizeIncreasingOrder(pdfFiles);
+                    break;
+                case SIZE_DECREASING_ORDER_INDEX:
+                    sortFilesBySizeDecreasingOrder(pdfFiles);
+                    break;
             }
             mViewFilesAdapter.setData(pdfFiles);
             mViewFilesListRecyclerView.setAdapter(mViewFilesAdapter);