NetStandard 2.0 support #136

alex-bogomaz · 2017-10-06T08:58:43Z

Now things around NetCore and NetStandard tooling are stabilized
and we can give a new life to @enricosada 's PR #126.

This PR should resolve #130. Please review.

Building

To build Netstandard 1.6 Unquote you need to have NetCore SDK 2.0:

>dotnet --info
.NET Command Line Tools (2.0.0-preview2-006497)

Now build.bat also builds Unquote.NetStandard\Unquote.NetStandard.fsproj project and
merges NetStandard 1.6 dll into existing NuGet package.

Tests

To run NetCore tests execute following:

cd UnquoteTests.NetCore
dotnet restore
dotnet test

Few notes:

CustomExceptionSerializationTests.fs tests are excluded:
because of limited serialization support in NetStandard 1.6.
The question here - should we have support of NetStandard 2.0 for Unquote and what are use-cases for such exception serialization?
Following test is skipped:

let ``ToUIntPtr primitive`` () =
    testEvalCheckedOverflow <@ Checked.unativeint UInt64.MaxValue @>

Not sure why this operation is not failing under NetCore.

Two following DecompilationTests are failing:
1. re-sugar partial application with first, single tuple arg applied
2. re-sugar partial application with first single arg applied and second tuple arg applied
  with errors like:

"ftupled 1 2" = "ftupled (1, 2)" 
false

but this is not something NetCore-related, but rather difference between F#4.0 and 4.1.
There are exactly same exceptions when compiling Unquote using VS 2017. In VS 2015 those 2 tests are green.

I've asked the question here: dotnet/fsharp#3698
but still have trouble understanding how to fix this issue in Unquote.

Testing frameworks support.

Assertions.fs includes Unquote NetStandard 1.6 support for Expecto, Xunit2 and NUnit3
frameworks.
To test support execute following:

Xunit2:

cd VerifyXunit2Support
dotnet restore VerifyXunit2Support.netcoreapp.fsproj
dotnet test VerifyXunit2Support.netcoreapp.fsproj

NUnit3:

cd VerifyNunit3Support
dotnet restore VerifyNUnit3Support.netcoreapp.fsproj
dotnet test VerifyNUnit3Support.netcoreapp.fsproj

Expecto:

cd VerifyExpectoSupport
dotnet restore VerifyExpectoSupport.netcoreapp.fsproj
dotnet run -p VerifyExpectoSupport.netcoreapp.fsproj

enricosada · 2017-10-06T09:58:58Z

@alex-bogomaz some notes:

use .net core sdk 2.0.0 (RTM)

dont use dotnet 2.0.0-preview2-006497, this is an old prerelease version. use 2.0.0 RTM

target .net standard 2.0, not 1.6.

and no need to target .net standard 1.6. go directly to netstandard2.0 is a lot better..
and netcoreapp2.0 if needed

use a sln file

as a note. if you want to can create a .sln file

dotnet new sln -n Unquote.netstandard`
dotnet add Unquote.netstandard.sln reference Unquote.NetStandard\Unquote.NetStandard.fsproj

etc.

so you can restore/build it at once

dotnet restore Unquote.netstandard.sln
dotnet build Unquote.netstandard.sln

this is also nicely supported in VSCODE 😄 and make easy to switch netcore/net

refresh template of test

is a good idea to refresh the templates of tests.

you do in a temp dir:

dotnet new xunit -lang F#

to generate an new xunit test project, and check the PackageReference versions with existing.
same for nunit

move test project in distinct directories

the project name can be the same.
but having multiple fsproj/csproj in same directory has issues, and should be avoided if possible

tomasaschan · 2017-10-10T20:40:57Z

Just want to put forth that I'm really grateful for someone tackling this. I'm very much looking forward to a NETStandard build of this library - keep it coming! 🎉

pkese · 2017-10-23T20:25:46Z

Pull request is available,
code review issues have been addressed,

so what's holding back the release?

stephen-swensen · 2017-10-23T21:05:22Z

Hey all - thanks for effort on this and sorry for slow response. I'll move towards getting this into master and released in the next few days.

My current thinking is that we'll do a major version bump here (Unquote 4.x) and drop support for .NET 4.0 and PCL 256 profiles.

stephen-swensen · 2017-10-29T22:29:55Z

@alex-bogomaz FYI I created an Unquote issue for the failing tests you discovered: #137 (thanks much for reporting the problem).

stephen-swensen · 2017-10-29T22:32:25Z

Unquote/Assertions.fs

@@ -62,6 +62,39 @@ module Internal =
 #if PORTABLE
        outputReducedExprsMsg outputGenericTestFailedMsg
 #else
+#if NETSTANDARD2_0


@alex-bogomaz is there are reason for limiting the set of supported frameworks for NetStandard 2.0 here?

The only reason was NetStandard support for each particular framework:

NUnit 3, Xunit 2 and Expecto - they support NetStandard 1.6.

Fuchu, Xunit 1, MBUnit - not

FSI - according to official MS announcements - it is not supported for NetCore yet: https://blogs.msdn.microsoft.com/dotnet/2017/08/14/f-and-net-core-roadmap-update/

@alex-bogomaz thanks, that makes sense. But I wonder if it matters that Fuchu, Xunit 1, MBUnit, and FSI don't support NetStandard since we are loading assemblies dynamically... I forget why we had to limit the PCL build to only the generic test failed function.

@stephen-swensen Fuchu is replaced by Expecto afaik.

good point. maybe we should not limit.
i'll test following scenario and get back with results:

use dot net sdk 2.0

create unit-test project, target net framework 461

reference netstandard 2.0 unquote

reference full-framework Fuchu

stephen-swensen · 2017-10-31T13:13:52Z

@enricosada @alex-bogomaz question: are there any practical downsides to targeting NetStandard 2.0 instead of NetStandard 1.6? i.e. will we be limiting the platform reach of our NetStandard build?

According to https://docs.microsoft.com/en-us/dotnet/standard/net-standard#net-platforms-support

"in general, we recommend you to target the lowest version of .NET Standard possible"
PCL profile 259 (which Unquote currently supports) is compatible with .NET Standard 1.0

alex-bogomaz · 2017-11-01T11:46:27Z

There is no testing frameworks support in PCL Unquote, so we really need Unquote for Standard 1.6 or 2.0 to get nice exceptions in Expecto etc.
As for Netstandard 1.6 - just like in PCL case there will be no "serializable" attribute and "serialization constructor" for exceptions like AssertionFailedException. This is the major difference for Unquote compared to Netstandard 2.0

If this is OK - we can target Standard 1.6.
Question here: what is the reason of having such constructors for Unquote exceptions?

Btw - i still need to check if we should limit number of supported testing frameworks for Netstandard...

stephen-swensen · 2017-11-01T20:12:44Z

@alex-bogomaz I think it is fine not to have custom exception serialization if that is the only limitation and NetStandard 1.6 opens up wider platform support. The request for supporting serialization in custom exceptions goes back to 2012: #98 ... I imagine it is a fairly niche use-case: "It is required for them to pass AppDomain boundaries".

enricosada · 2017-11-02T10:42:35Z

Just ignore net standard1.6, target only 2.0 The 2.0 is the only one who matter. The 1.6 doesn't add more (not obsolete) net profiles To justify it, and tooling isn't there for it. The new lts is soon the 2.0 From mobile

…

-- Enrico Sada @enricosada

________________________________ From: Stephen Swensen <notifications@github.com> Sent: Wednesday, November 1, 2017 9:12:45 PM To: SwensenSoftware/unquote Cc: Enrico Sada; Mention Subject: Re: [SwensenSoftware/unquote] NetStandard 2.0 support (#136) @alex-bogomaz<https://github.com/alex-bogomaz> I think it is fine not to have custom exception serialization if that is the only limitation and NetStandard 1.6 opens up wider platform support. The request for supporting serialization in custom exceptions goes back to 2012: #98<#98> ... I imagine it is a fairly niche use-case: "It is required for them to pass AppDomain boundaries". — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#136 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAI_K5VagbMQkLbqTPBkbT3s0yYwTmlaks5syNC9gaJpZM4PwL-g>.

alex-bogomaz · 2017-11-07T15:17:12Z

hi, so we are keeping NetStandard 2.0 - right?

stephen-swensen · 2017-11-07T17:46:26Z

@alex-bogomaz yeah sounds like that's the way to go

stephen-swensen · 2017-11-10T03:19:57Z

Closing this pull request: I merged the changes to master from command line. Prepping for release now. Thanks @alex-bogomaz and @enricosada for contributing this work!

alex-bogomaz added 5 commits October 4, 2017 14:10

Port library to netstandard 1.6

4ac8527

Ported test to Net Core 1.1

055bfb5

Port appropriate "verify" projects to netcore1.1

3eb0e2f

Fix PROTABLE build

2e0c065

Merge nuget packages

10e237d

alex-bogomaz added 3 commits October 9, 2017 14:40

Added netcore sln. Fix appveyor build

513d3c0

Upgrade NUnit3 for netcore

50dc59b

netstandard 2.0 instead of 1.6

d6b4998

stephen-swensen changed the title ~~NetStandard 1.6 support~~ NetStandard 2.0 support Oct 29, 2017

stephen-swensen reviewed Oct 29, 2017

View reviewed changes

Added back support of Fuchu and Xunit1 to netstandard 2.0 assertions

f71606a

stephen-swensen closed this Nov 10, 2017

This was referenced Nov 23, 2017

Support for .NET Standard cryptean/bitcoinlib#52

Closed

Support .NET Standard hedgehogqa/fsharp-hedgehog#45

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NetStandard 2.0 support #136

NetStandard 2.0 support #136

alex-bogomaz commented Oct 6, 2017

enricosada commented Oct 6, 2017 •

edited

Loading

tomasaschan commented Oct 10, 2017

pkese commented Oct 23, 2017 •

edited

Loading

stephen-swensen commented Oct 23, 2017

stephen-swensen commented Oct 29, 2017

stephen-swensen Oct 29, 2017

alex-bogomaz Oct 30, 2017

stephen-swensen Oct 30, 2017

enricosada Oct 30, 2017

alex-bogomaz Oct 30, 2017

stephen-swensen commented Oct 31, 2017

alex-bogomaz commented Nov 1, 2017

stephen-swensen commented Nov 1, 2017

enricosada commented Nov 2, 2017 via email

alex-bogomaz commented Nov 7, 2017

stephen-swensen commented Nov 7, 2017

stephen-swensen commented Nov 10, 2017

NetStandard 2.0 support #136

NetStandard 2.0 support #136

Conversation

alex-bogomaz commented Oct 6, 2017

Building

Tests

Testing frameworks support.

enricosada commented Oct 6, 2017 • edited Loading

use .net core sdk 2.0.0 (RTM)

target .net standard 2.0, not 1.6.

use a sln file

refresh template of test

move test project in distinct directories

tomasaschan commented Oct 10, 2017

pkese commented Oct 23, 2017 • edited Loading

stephen-swensen commented Oct 23, 2017

stephen-swensen commented Oct 29, 2017

stephen-swensen Oct 29, 2017

Choose a reason for hiding this comment

alex-bogomaz Oct 30, 2017

Choose a reason for hiding this comment

stephen-swensen Oct 30, 2017

Choose a reason for hiding this comment

enricosada Oct 30, 2017

Choose a reason for hiding this comment

alex-bogomaz Oct 30, 2017

Choose a reason for hiding this comment

stephen-swensen commented Oct 31, 2017

alex-bogomaz commented Nov 1, 2017

stephen-swensen commented Nov 1, 2017

enricosada commented Nov 2, 2017 via email

alex-bogomaz commented Nov 7, 2017

stephen-swensen commented Nov 7, 2017

stephen-swensen commented Nov 10, 2017

enricosada commented Oct 6, 2017 •

edited

Loading

pkese commented Oct 23, 2017 •

edited

Loading