Recent changes break bi-direction communication on MSZ-GL06NA

[stewartadam]

I'm using this library via esphome-mitsubishiheatpump.

Commit cea90c5 works as expected, but any commit later causes bi-directional serial communication to silently fail. Updates sent do nothing and no updates are received from the heat pump, so the current setpoint shows as NaN.

[SwiCago]

@prashker , this relates to the commit you made, can you review pls

[prashker]

@SwiCago if I'm reading the above correctly, my commit works - it is subsequent commits breaking communication.

@stewartadam seems to indicate that problem is immediately after my commit, which would be ce460c3 by @dzungpv

[dzungpv]

@SwiCago if I'm reading the above correctly, my commit works - it is subsequent commits breaking communication.

@stewartadam seems to indicate that problem is immediately after my commit, which would be ce460c3 by @dzungpv

I am running for months without any issue. Both with esp8266 and esp32. With my changes, if you are not set the custom UART pin on ESP32, it use default settings. @stewartadam can you try my project, it is not ESPHOME but you can try to test if the bug happen with this lib or ESPHOME implementation

[markalston]

@dzungpv It looks like your issue is that you are only setting the values for rxPin and txPin inside the

if (rx >= 0 && tx >= 0) {

test.

If on the initial call to connect, rx and tx are set to -1 then rxPin and txPin are not set but you use them on line 119.

_HardSerial->begin(bitrate, SERIAL_8E1, rxPin, txPin);

Maybe you could initialize them to -1 and add a test to check value before line 119 in case it is -1 and then fallback to the old

_HardSerial->begin(bitrate, SERIAL_8E1);

This is my guess to the issue anyway.

[dzungpv]

@dzungpv It looks like your issue is that you are only setting the values for rxPin and txPin inside the

if (rx >= 0 && tx >= 0) {

test.

If on the initial call to connect, rx and tx are set to -1 then rxPin and txPin are not set but you use them on line 119.

_HardSerial->begin(bitrate, SERIAL_8E1, rxPin, txPin);

Maybe you could initialize them to -1 and add a test to check value before line 119 in case it is -1 and then fallback to the old

_HardSerial->begin(bitrate, SERIAL_8E1);

This is my guess to the issue anyway.

It is original code, I just store the custom RX TX pin for call in retry you can check change here: dzungpv@ce460c3 and 4 of my units running fine since, 3 esp8266 and 1 esp32
Update: because I am using custom pin so ESP32 not show error @SwiCago you can check the PR to fix the bug

[dzungpv]

@stewartadam Can you check latest change?

[stewartadam]

Just tried it, confirmed working! Thank you @dzungpv and @markalston

[SwiCago]

Thanks @dzungpv , @stewartadam , @markalston
Great work of finding a solution for everyone fast...Pull has been merged.

[prashker]

Teamwork!