Fix version pinning of SwiCago/HeatPump library #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reported SwiCago/HeatPump#207 upstream. |
|
SwiCago/HeatPump#207 has been fixed upstream, so I've updated the version pin to point to the merge commit for its PR#209 that includes a fix when the library is initialized without specifying custom gpio pins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pins the library to SwiCago/HeatPump@cea90c5 which is the last stable commit I was able to test with my MSZ-GL06NA. More recent commits cause serial communication to silently fail (fixes #71 for me).
This PR also moves the version pin into the repository parameter as the
versionproperty ofcg.add_library()appears to be entirely ignored in favor of version provided by the metadata in the repository instead. Since SwiCago doesn't version its library, we should version by Git commit instead.Prior to this change, the latest commit was always being used which is why the issue in #71 suddenly appeared for me after rebuilding my m5stamp pico firmwares with no other changes.