Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating Colors from txt files will stop generation on comments and blank lines #140

Closed
dostrander opened this issue Jun 18, 2016 · 6 comments · Fixed by #141
Closed

Comments

@dostrander
Copy link
Collaborator

If you have comments (lines starting with # ) within your Colors.txt file it will bail when it hits those comments.

@dostrander dostrander changed the title Generating Colors from txt files will stop generation on comments # Generating Colors from txt files will stop generation on comments Jun 18, 2016
@AndrewSB
Copy link
Contributor

Colors.txt also no longer supports blank lines. It silently fails and doesn't output all colors after the first newline in the file

@dostrander
Copy link
Collaborator Author

@AndrewSB When was that introduced and what is the reasoning behind the decision?

@AndrewSB
Copy link
Contributor

@dostrander I am unsure, but recently (yesterday) when I ran Swiftgen I got a bunch of compile errors saying my color enum cases weren't defined, I removed all the blank lines I'd had in the file and it was fixed.

My colors.txt has had those blank lines for a better part of 6 months now.

This may have something to do with Updating to the beta Mac OS, but I'm not sure and have no idea why it would - the two events just seem correlated.

More probably it has something to do with the changes to color.txt parsing in release 1.0.0 or 1.1.0

@AndrewSB
Copy link
Contributor

Can we edit the title of this issue to end with "comments or blank lines"?

@dostrander
Copy link
Collaborator Author

@AndrewSB Just verified this is a problem.

The fix I did in PR #141 will also fix the blank lines

@dostrander dostrander changed the title Generating Colors from txt files will stop generation on comments Generating Colors from txt files will stop generation on comments and blank lines Jun 20, 2016
@AndrewSB
Copy link
Contributor

Looks great, this issue looks closable pending the PR merge

AliSoftware added a commit that referenced this issue Jun 20, 2016
Colors.txt file format: comment & empty lines bug

Closes #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants