-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating Colors from txt files will stop generation on comments and blank lines #140
Comments
#
Colors.txt also no longer supports blank lines. It silently fails and doesn't output all colors after the first newline in the file |
@AndrewSB When was that introduced and what is the reasoning behind the decision? |
@dostrander I am unsure, but recently (yesterday) when I ran Swiftgen I got a bunch of compile errors saying my color enum cases weren't defined, I removed all the blank lines I'd had in the file and it was fixed. My colors.txt has had those blank lines for a better part of 6 months now. This may have something to do with Updating to the beta Mac OS, but I'm not sure and have no idea why it would - the two events just seem correlated. More probably it has something to do with the changes to color.txt parsing in release 1.0.0 or 1.1.0 |
Can we edit the title of this issue to end with "comments or blank lines"? |
Looks great, this issue looks closable pending the PR merge |
Colors.txt file format: comment & empty lines bug Closes #140
If you have comments (lines starting with
#
) within your Colors.txt file it will bail when it hits those comments.The text was updated successfully, but these errors were encountered: