New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cocoapods 1.9 #619
Cocoapods 1.9 #619
Conversation
Hey 👋 I'm Eve, the friendly bot watching over SwiftGen 🤖 Thanks a lot for your contribution! Once you fix those tiny nitpickings above, we should be good to go! 🙌 ℹ️ I will update this comment as you add new commits Generated by 🚫 Danger |
Would you look at that, 4 seconds (without cache) 😆 🚗💨 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also remove the deprecated .swift-version
from the repo and use the swift_versions
DSL attribute in the podspec instead
Uhm we can add the |
d461d96
to
1db0c28
Compare
1db0c28
to
6b1555c
Compare
6b1555c
to
f0707d4
Compare
f0707d4
to
1e94278
Compare
5e9d77d
to
0223f8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the fact that we should stop probably caching the CDN (and thus winning some more CI time by avoiding to restore it when not needed), LGTM
- save_cache: | ||
key: cocoapods-{{ checksum "Podfile.lock" }} | ||
paths: | ||
- ~/.cocoapods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With CDN, is it really still worth it to cache the ~/.cocoapods
folder? From experience on other repos it doesn't really seem to be much necessary anymore.
We already commit the Pods/
folder (and if we didn't, we could cache it) so it should be quite rare to have the need for the spec repo to be present and downloaded locally anyway, as it is now supposed to only be necessary during pod update
(or if pod install
needs to actually install pods that were missing in Pods/
and were not at a version that was matching was was locked in Podfile.lock
, which in our case should never happen on CI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iow, if you remove those steps from CI, and as long as we still commit the Pods/
folder and that Podfile.lock
and Pods/Manifest.lock
are properly in sync, I think pod install
is now a no-op that shouldn't even require the CDN to be cloned at all.
Maybe I'm wrong so don't hesitate to make some tests to validate that if unsure.
@@ -4,19 +4,19 @@ source 'https://rubygems.org' | |||
|
|||
# The bare minimum for building, e.g. in Homebrew | |||
group :build do | |||
gem 'rake', '~> 12.3' | |||
gem 'rake', '~> 13.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 This should get rid of the security risk issue too 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the risk of using cache for specs repo was that cache restoration (download+unzip) and save (zip + upload) would risk taking more time than cloning the CDN. But after looking into it, I see that cache restoration only takes 3s. So we might as well keep it
2 things of note:
generate_multiple_pod_projects
andincremental_installation
, which should reduce the amount of changes duringpod install/update
.