New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cocoapods 1.9 #619
Merged
Merged
Cocoapods 1.9 #619
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5bb9da4
update gems
djbe 48b1090
pod install
djbe 215f984
Use CDN source
djbe 74ce649
Use multiple pod projects
djbe 408d005
Tweak CI to cache specs
djbe 391b227
`check-deploy` should be quick enough that it can start directly
djbe 29a4b61
Changelog entry
djbe a8a1741
Xcode 11 warnings
djbe 0223f8b
Use latest CircleCI xcode image
djbe 4743f13
Merge branch 'develop' into feature/cocoapods-1.7-beta
AliSoftware File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
2.5.7 | ||
2.6.5 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,19 +4,19 @@ source 'https://rubygems.org' | |
|
||
# The bare minimum for building, e.g. in Homebrew | ||
group :build do | ||
gem 'rake', '~> 12.3' | ||
gem 'rake', '~> 13.0' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎉 This should get rid of the security risk issue too 👍 |
||
gem 'xcpretty' | ||
end | ||
|
||
# In addition to :build, for contributing | ||
group :development do | ||
gem 'cocoapods', '~> 1.6.0' | ||
gem 'rubocop', '~> 0.65' | ||
gem 'cocoapods', '~> 1.9.0' | ||
gem 'rubocop', '~> 0.80' | ||
gem 'danger' | ||
end | ||
|
||
# For releasing to GitHub | ||
group :release do | ||
gem 'octokit', '~> 4.13' | ||
gem 'octokit', '~> 4.16' | ||
gem 'plist', '~> 3.5' | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With CDN, is it really still worth it to cache the
~/.cocoapods
folder? From experience on other repos it doesn't really seem to be much necessary anymore.We already commit the
Pods/
folder (and if we didn't, we could cache it) so it should be quite rare to have the need for the spec repo to be present and downloaded locally anyway, as it is now supposed to only be necessary duringpod update
(or ifpod install
needs to actually install pods that were missing inPods/
and were not at a version that was matching was was locked inPodfile.lock
, which in our case should never happen on CI)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iow, if you remove those steps from CI, and as long as we still commit the
Pods/
folder and thatPodfile.lock
andPods/Manifest.lock
are properly in sync, I thinkpod install
is now a no-op that shouldn't even require the CDN to be cloned at all.Maybe I'm wrong so don't hesitate to make some tests to validate that if unsure.