Configure CircleCI #10
Conversation
djbe
force-pushed
the
feature/circleci
branch
from
a2bf1a4
to
f5b6fb2
Compare
djbe
force-pushed
the
feature/circleci
branch
from
d1b8ec7
to
2499882
Compare
djbe
force-pushed
the
feature/circleci
branch
from
04ee92e
to
c2d308b
Compare
djbe
force-pushed
the
feature/circleci
branch
from
8efef22
to
a332b55
Compare
Podfile
Outdated
| @@ -1,8 +1,7 @@ | |||
| platform :osx, '10.9' | |||
| platform :osx, '10.12' | |||
There was a problem hiding this comment.
Why this bump? Are we now using APIs in SwiftGenKit that are only available in 10.12?
There was a problem hiding this comment.
(If that were the case our podspec file would be wrong so I guess that's not the reason)
There was a problem hiding this comment.
No, just trying to always have the latest libs and deprecation warnings (should we get any). I'll revert this for now
| else if let lhs = lhs as? String, let rhs = rhs as? String, lhs == rhs { return nil } | ||
| else if let lhs = lhs as? [Any], let rhs = rhs as? [Any], lhs.count == rhs.count { | ||
|
|
||
| if let lhs = lhs as? Bool, let rhs = rhs as? Bool, lhs == rhs { return nil |
There was a problem hiding this comment.
If we're going to go to the next line for the closing brace (probably because SwiftLint wants us to right?) I'd prefer to go to the next line after the opening brace too to be consistent.
| @@ -0,0 +1,28 @@ | |||
| namespace :lint do | |||
There was a problem hiding this comment.
I expect those files in rakelib are gonna be copied over from Eve (that would serve as our source of truth for those utils) once generalized on all our repos?
There was a problem hiding this comment.
Stencilswiftkit and this repo match fairly well. The templates repo has some small differences, the swiftgen one even more. So no idea how far we can go in unifying these
There was a problem hiding this comment.
Yeah given their specifics (one not being code to compile as a framework but rather templates, the other being a CLI that we need to wrap manually) I can guess why they might be different. I just don't want to repeat code and more importantly risk any discrepancy between them or bugs being fixed in one place but not the other…
But that will probably be work for a dedicated PR in Eve once everything is merged and works then.
rakelib/utils.rake
Outdated
| def xcpretty(cmd, task, subtask = '') | ||
| name = (task.name + (subtask.empty? ? '' : "_#{subtask}")).gsub(/[:-]/, "_") | ||
| command = [*cmd].join(' && ') | ||
| xcpretty = `which xcpretty` |
There was a problem hiding this comment.
Same remarks for rakelib/lint.rake rakelib/utils.rake here than the ones in SwiftGen/SwiftGen#269 (review)
djbe
force-pushed
the
feature/circleci
branch
from
4a11051
to
419020f
Compare
djbe
force-pushed
the
feature/circleci
branch
from
419020f
to
4714161
Compare
Fixes #8, keep track of SwiftGen/StencilSwiftKit#20 for any changes that need to be copied here.