fix: generate proper warning if audio inputs are not setup for passth…

…rough
Swiftb0y · May 24, 2024 · 23493c6 · 23493c6
1 parent 0907188
commit 23493c6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/res/controllers/Roland_DJ-505-scripts.js b/res/controllers/Roland_DJ-505-scripts.js
@@ -371,6 +371,9 @@ DJ505.crossfader.setReverse = function(channel, control, value, _status, _group)
 DJ505.setChannelInput = function(channel, control, value, _status, _group) {
     const number = (channel === 0x00) ? 0 : 1;
     const channelgroup = "[Channel" + (number + 1) + "]";
+    if (engine.getValue(channelgroup, "input_configured") === 0) {
+        throw "Configuration Error: Mapping expects audio inputs to be configured! please refer to https://manual.mixxx.org/latest/hardware/controllers/roland_dj_505#audio-setup";
+    }
     switch (value) {
     case 0x00:  // PC
         engine.setValue(channelgroup, "passthrough", 0);

diff --git a/res/controllers/Roland_DJ-505.midi.xml b/res/controllers/Roland_DJ-505.midi.xml
@@ -3,7 +3,7 @@
     <info>
         <name>Roland DJ-505</name>
         <author>Jan Holthuis</author>
-        <description>4-deck mapping for Roland DJ-505 controller</description>
+        <description>4-deck mapping for Roland DJ-505 controller. Make sure you setup audio outputs and inputs correctly (see manual)</description>
         <forums>https://mixxx.discourse.group/t/roland-dj-505/17916</forums>
         <manual>roland_dj_505</manual>
     </info>