Rename isExists to exists. Fixes #448 #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Really nice, simple change that improves the readability of the API. |
|
Nice!!! |
lingoer
added a commit
that referenced
this pull request
Mar 15, 2016
Rename isExists to exists. Fixes #448
zetavg
added a commit
to zetavg/react-native-ios-charts
that referenced
this pull request
May 2, 2016
isExists() for JSON has not been add upon SwiftyJSON 2.3.1, and is renamed to exists() in this later PR: SwiftyJSON/SwiftyJSON#457. Specifying "~> 2.3.0" might not work, and let users run into the following error: ``` error: value of type 'JSON' has no member 'isExists' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isExists()isn't the correct way to phrase that statement and makes the code harder to read. Simply usingexists()makes it easer to read and grammatically correct.