Update foundation 5 to foundation-sites 6 #1009
Conversation
Aligns with new foundation-sites syntax Update __foundation-index.scss Add foundation-sites, foundation-everything mixin Update __foundation-navbar.html Update to foundation-sites Update __navbar.scss Handful of changes for foundation-sites Update package.json Update dependencies to stable releases
|
The bower dependency needs to also be changed from |
| "sinon": "~1.17.1", | ||
| "mz": "~2.3.1", | ||
| "recursive-readdir": "~1.3.0", | ||
| "sinon": "~1.17.3", |
There was a problem hiding this comment.
Just going off of the depedency monitor. I'm unopininated about it. https://david-dm.org/eleven-labs/generator-gulp-angular#info=devDependencies&view=table
|
I don't see a version bump in the bower.json, I missed something ? |
|
You mean here? https://github.com/Swiip/generator-gulp-angular/blob/master/generators/app/templates/_bower.json#L43 I wasn't 100% sure where that change should go - if that is the correct place, I can add it in. |
|
Yep that's it |
|
I have a suggested update to the test-bower package - the first error is failing because it is looking for I am not sure what the second failure is about, though. I wouldn't have made any changes to I also reversed the changes to |
|
Wanted to just bump this re:update to |
Update __foundation.html
Aligns with new foundation-sites syntax
Update __foundation-index.scss
Add foundation-sites, using foundation-everything mixin
Update __foundation-navbar.html
Aligns with new foundation-sites syntax
Update __navbar.scss
Handful of changes for foundation-sites
Update package.json
Update dependencies to stable releases