Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests in XCode 10 #371

Merged
merged 2 commits into from
Sep 18, 2018
Merged

Fix tests in XCode 10 #371

merged 2 commits into from
Sep 18, 2018

Conversation

janhalousek
Copy link
Contributor

@janhalousek janhalousek commented Sep 17, 2018

Fixes failing tests in XCode 10

This MR is superset of #369 and probably resolves issues #368, #367 (haven't tested all cases)��.

The problem lies in casting nil variable to Any type, which seems to be a new thing in XCode 10 / Swift 4.2

class Bar {}
var foo: Bar? = nil

if let fooUnwrapped = foo as? Any {
    // this passes and fooUnwrapped is Optional(nil)
}

@jakubvano
Copy link
Member

Thanks for the PR! 👍
I will try to release Swift 4.2 compatible version ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants