Skip to content

Commit

Permalink
Remove cleanup when moving off UIWindow. Closes #23.
Browse files Browse the repository at this point in the history
Initially, this was added to prevent retain cycles caused by SwipeAction handlers capturing self.  Instead, it should be left up to the implementor to use [weak self] in handler implementations or ensure the action view is hidden before dismissing/popping a temporary parent view controller.  I've verified this behaves the same way as UITableViewRowAction.
  • Loading branch information
jerkoch committed Mar 26, 2017
1 parent 95889a1 commit da6f87f
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions Source/SwipeTableViewCell.swift
Original file line number Diff line number Diff line change
Expand Up @@ -113,15 +113,6 @@ open class SwipeTableViewCell: UITableViewCell {
}
}

/// :nodoc:
open override func willMove(toWindow newWindow: UIWindow?) {
super.willMove(toWindow: newWindow)

if newWindow == nil {
reset()
}
}

/// :nodoc:
override open func setEditing(_ editing: Bool, animated: Bool) {
super.setEditing(editing, animated: animated)
Expand Down

0 comments on commit da6f87f

Please sign in to comment.