Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwind Segue causes SwipeAction button menu to disappear #23

Closed
seenoevo opened this issue Mar 26, 2017 · 3 comments
Closed

Unwind Segue causes SwipeAction button menu to disappear #23

seenoevo opened this issue Mar 26, 2017 · 3 comments
Labels
Milestone

Comments

@seenoevo
Copy link

seenoevo commented Mar 26, 2017

@jerkoch I just found a bug where, if using a UINavigationController, if the SwipeAction menu is currently opened when another View Controller is pushed onto the stack, then an unwind segue is performed back to the main View Controller, the SwipeAction menu buttons disappear.

To get the SwipeAction menu to show again, you have to swipe left on that cell.

Here's a screenshot:

Before Unwind Segue:
fullsizerender

After Unwind Segue:
fullsizerender-2

Currently, the only fix I can across is to reload the tableview in whatever function returned from when an Unwind segue occurs so that the SwipeAction menu disappears.

@jerkoch jerkoch added the bug label Mar 26, 2017
@jerkoch jerkoch added this to the 1.6.0 milestone Mar 26, 2017
@seenoevo
Copy link
Author

seenoevo commented Mar 29, 2017

thanks @jerkoch for both bug fixes, however there is a new issue

originally I had the following set up:

    func tableView(_ tableView: UITableView, editActionsOptionsForRowAt indexPath: IndexPath, for orientation: SwipeActionsOrientation) -> SwipeTableOptions
    {
        var options = SwipeTableOptions()
        
        options.expansionStyle = .none
        options.transitionStyle = .border
        options.maximumButtonWidth = 0
        options.buttonPadding = 0
        
        return options
    }

However, with the new bug fixes, .border does not collapse the SwipeAction buttons, but it looks to be .reveal.

Also, the expansionStyle of .none does not work as illustrated, I feel like it's a combination of .selection and .destructive.

Here's a sample project illustrating what I mean:

Test.zip

@jerkoch
Copy link
Contributor

jerkoch commented Mar 29, 2017

Hey @seenoevo - Thanks for finding this! You caught the one setup that I didn't try. 😕

Standby for a fix!

jerkoch added a commit that referenced this issue Mar 29, 2017
@seenoevo
Copy link
Author

@jerkoch issue fixed

thanks for the quick update and support

I'll let you know if I find any other bugs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants