Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should wait for server to be ready before redirecting #12

Closed
rokroskar opened this issue Jun 14, 2018 · 1 comment · Fixed by #13
Closed

should wait for server to be ready before redirecting #12

rokroskar opened this issue Jun 14, 2018 · 1 comment · Fixed by #13
Assignees
@rokroskar
Labels
blocker bug Something isn't working help wanted Extra attention is needed

Comments

@rokroskar
Copy link
Member

rokroskar commented Jun 14, 2018 •
edited
Loading

If the notebook server takes a long time to spawn (e.g. because images have to be downloaded), JH will wait for 30 seconds and then redirect to a url like .../hub/user/... which fails with a 401 because it's not actually a valid URL (it still gets proxied to the notebooks service for some reason which queries gitlab for a non-existent project, hence the 401).

The way to fix this is to wait until the server is ready before redirecting. It's unclear how to get this information.

moved from SwissDataScienceCenter/renku#210 -- see SwissDataScienceCenter/renku#210 (comment)
@rokroskar rokroskar added bug Something isn't working help wanted Extra attention is needed labels Jun 14, 2018
@rokroskar rokroskar mentioned this issue Jun 14, 2018
Closed
@erbou
Copy link

erbou commented Jun 14, 2018

Can we have a description of the symptoms of this bug? I am not sure if I am facing the same issue or if that should be another issue.

@erbou erbou closed this as completed Jun 14, 2018
@erbou erbou reopened this Jun 14, 2018
@rokroskar rokroskar self-assigned this Jun 14, 2018
rokroskar added a commit that referenced this issue Jun 14, 2018
@rokroskar
wait for server to spawn before redirecting
2d34ed2 
closes #12
@rokroskar rokroskar mentioned this issue Jun 14, 2018
Merged
rokroskar added a commit that referenced this issue Jun 14, 2018
@rokroskar
wait for server to spawn before redirecting
9f564da 
closes #12
rokroskar added a commit that referenced this issue Jun 15, 2018
@rokroskar
wait for server to spawn before redirecting
579d9c8 
    closes #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rokroskar rokroskar

Labels
blocker bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wait for server to spawn before redirecting SwissDataScienceCenter/renku-notebooks
2 participants
@rokroskar @erbou